feat(assets): add dual-origin AssetInput field - #211
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_89dfdd15-b533-4cfb-91c3-eabb0db17f11) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
IAnMove
added a commit
that referenced
this pull request
Sep 7, 2026
Code healthQuality score: 54.0/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
Expose From my computer and From HocusPocus on the same control. Native file cancel does not mutate the field; uploads abort on unmount.
IAnMove
force-pushed
the
feat/asset-picker-input
branch
from
September 7, 2026 09:23
22db8bf to
9c6d43e
Compare
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetInput: From my computer (native file dialog) and From HocusPocus (shared explorer)./api/v1/uploadand/api/v1/upload-audio; abort on unmount so a late response cannot apply.CURRENT_WORK.md/ i18npicker.*may need a trivial rebase if PR 3 lands first.Test plan
assetInput.test.tsx— kind inference, native cancel, explorer open, Remove, failed uploadCoste de la tarea
Note
Low Risk
Additive picker primitive with tests and upload abort guards; no broad migration of existing form fields in this diff.
Overview
Adds
AssetInput, the asset-picker PR 4 control that exposes two explicit sources—from device (hidden file input + drag-and-drop) and from HocusPocus (existingAssetExplorerDialog)—on top ofAssetPickTrigger, with optional Remove separate from explorer cancel.Introduces
upload.ts(inferUploadKind,uploadLocalAsset,createUploadSession) to post locals through existinguploadAudio/uploadImage(/api/v1/upload-audioand/api/v1/upload), map results intoApiOutput, and abort in-flight uploads on unmount so late responses cannot callonChoose. Newpicker.*strings in EN/ES cover device/library/remove/upload states.Exports
AssetInputand upload helpers fromfeatures/asset-picker;assetInput.test.tsxcovers kind inference, empty native pick, library open/cancel, remove, and failed upload after unmount. Docs shift active work from modal PR 2 to PR 4 (CURRENT_WORK.md,ASSET_PICKER_MIGRATION.mdhotspots); explorer preview/chrome remain out of scope.Reviewed by Cursor Bugbot for commit 50065f4. Configure here.