feat(assets): make the shared explorer confirm transactionally - #208
Merged
Conversation
Stop preselecting the first card and confirming on double-click. Sort and filter the full list before paging, keep a provisional choice when items refresh, and treat None as clear rather than Cancel.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b377d6a3-b88e-4823-a8b9-fae4def9c91f) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 53.9/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
AssetExplorerBody was a new hotspot at 27 (limit 25). Move toolbar, gallery, preview and footer into smaller components.
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetExplorerDialogto the PR 2 contract while keeping theApiOutputwrapper for feat(video3d): add a real 3D stage beside the 2.5D compositor #198 consumers (SceneAnimatorExplorer,SceneRecipePanel,Scene3DWorkspace).created_desc|created_asc|name_asc|name_desc) and search apply to the full list before paging (24 cards).created_at(unknown date if missing), nevercompleted_at. EN/ES catalog keys for sort/filter/empty/error.origin/developmentf1855ab7(feat(assets): add picker contract, adapters, and catalog sort #207 mixed). Does not add RAM-heavy previews (PR 3) or dual-origin field (PR 4). Do not merge until asked.Test plan
assetExplorerDialog.test.tsx+assetPickerContract.test.ts— 17 passednpm run i18n:check, eslint on touched UI files,tsc -bscripts/verify_clean_repo.pyCoste de la tarea
Note
Medium Risk
Shared explorer used across 2.5D/3D compositor flows changes confirm semantics and selection rules; regressions would affect asset assignment but the public
ApiOutputcallback shape is preserved.Overview
AssetExplorerDialogis updated to the asset-picker PR 2 modal contract while still callingonChoosewithApiOutputfor existing #198 consumers.Selection is transactional: cards only set a provisional pick; Choose commits and Cancel / overlay close abort without mutating the field. Double-click no longer confirms, the first item is not preselected, and None (when
allowNone) explicitly clears. Choose stays disabled until a compatible, in-catalog selection exists.The body now maps outputs through
outputToPickerItem, with sharedfilterPickerItems/sortPickerItems/paginatePickerItems(localQuery.ts, page size 24), toolbar sort and kind filters, optionalconstraints+checkCompatibility, andloading/error+ retry props. Preview/metadata use picker titles andcreated_at(notcompleted_at). EN/ES explorer strings were added; dev docs mark #207 merged and PR 2 in flight. Tests cover the new UX and client sort/filter behavior.Reviewed by Cursor Bugbot for commit 5be6ce1. Configure here.