feat(assets): play explorer preview on demand - #210
Merged
Conversation
Arm video/audio/GLB only in the preview pane, pause and unload on change or close, and never mount 24 players. Play does not confirm.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_1c299da7-882b-4a51-807b-b091d92b281f) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.0/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.1 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
srcon selection change and unmount. GLB uses lazymodel-viewer.previewPlayer.tsx,AssetExplorerChrome.tsx. Does not add AssetInput (PR 4).origin/development4cce2452(feat(assets): make the shared explorer confirm transactionally #208 and feat(video3d): cafe-dance set with textured building, floor and street #209 mixed). Do not merge until asked.Test plan
assetExplorerPreview.test.tsx— no video until Play; switch pauses; unmount pauses; Play does not confirmassetExplorerDialog.test.tsxstill passesCoste de la tarea
Note
Low Risk
Scoped UI preview lifecycle in the asset explorer; no auth, persistence, or API changes. Main risk is client memory/media edge cases, mitigated by on-demand load and teardown.
Overview
Adds asset picker PR 3: the explorer preview pane now uses a shared
AssetPreviewPlayerinstead of static thumbnails only.Preview behavior: Images load immediately in the side panel. Video, audio, and GLB stay on a poster/thumbnail until the user taps Play / 3D view; files over 80 MiB show a “large file” prompt before arming. One active player at a time—switching selection or unmounting pauses and clears media
src; GLB uses lazy@google/model-viewer. Gallery cards are unchanged (posters/icons only); Play does not confirm the pick.Also: EN/ES strings for play, 3D view, preview failure, and large-file copy;
assetExplorerPreview.test.tsxcovers lazy mount, pause on switch/unmount, and non-confirming play; migration docs andCURRENT_WORK.mdmark modal #208 integrated and track this branch as PR 3 in progress.Reviewed by Cursor Bugbot for commit 9fc98f3. Configure here.