Skip to content

feat(assets): play explorer preview on demand - #210

Merged
IAnMove merged 2 commits into
developmentfrom
feat/asset-picker-preview
Sep 7, 2026
Merged

feat(assets): play explorer preview on demand#210
IAnMove merged 2 commits into
developmentfrom
feat/asset-picker-preview

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • assetExplorerPreview.test.tsx — no video until Play; switch pauses; unmount pauses; Play does not confirm
  • existing assetExplorerDialog.test.tsx still passes
  • i18n, eslint, local code-health ratchet
  • Cursor review: not run (quota)

Coste de la tarea

  • Tests simulados: 0 tokens externos
  • Tests reales: N/A
  • Llamadas LLM externas: 0
  • Tokens de prompt: N/A
  • Tokens de respuesta: N/A
  • Tokens totales: N/A
  • Generaciones de imágenes/audio/vídeo: 0
  • Tiempo transcurrido: N/A
  • Proveedores/modelos: N/A

Note

Low Risk
Scoped UI preview lifecycle in the asset explorer; no auth, persistence, or API changes. Main risk is client memory/media edge cases, mitigated by on-demand load and teardown.

Overview
Adds asset picker PR 3: the explorer preview pane now uses a shared AssetPreviewPlayer instead of static thumbnails only.

Preview behavior: Images load immediately in the side panel. Video, audio, and GLB stay on a poster/thumbnail until the user taps Play / 3D view; files over 80 MiB show a “large file” prompt before arming. One active player at a time—switching selection or unmounting pauses and clears media src; GLB uses lazy @google/model-viewer. Gallery cards are unchanged (posters/icons only); Play does not confirm the pick.

Also: EN/ES strings for play, 3D view, preview failure, and large-file copy; assetExplorerPreview.test.tsx covers lazy mount, pause on switch/unmount, and non-confirming play; migration docs and CURRENT_WORK.md mark modal #208 integrated and track this branch as PR 3 in progress.

Reviewed by Cursor Bugbot for commit 9fc98f3. Configure here.

Arm video/audio/GLB only in the preview pane, pause and unload on
change or close, and never mount 24 players. Play does not confirm.
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_1c299da7-882b-4a51-807b-b091d92b281f)

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 7 file(s); +235/-15; React UI, docs

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/src/features/asset-picker/previewPlayer.tsx, ui/tests/assetExplorerPreview.test.tsx
  • modified: docs/development/ASSET_PICKER_MIGRATION.md, docs/development/CURRENT_WORK.md, ui/src/components/common/AssetExplorerChrome.tsx, ui/src/i18n/locales/en/common.json, ui/src/i18n/locales/es/common.json

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Code health

Quality score: 54.0/100

Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.

Component Weight Current Change
Cyclomatic health 45% 54.2 +0.0
File concentration 25% 60.6 +0.0
Oversized-file debt 20% 36.0 +0.0
Modularity 10% 72.2 +0.1

Change vs PR base: +0.1 points.

Metric Value
Production LOC 261,048
Production files 661
Test LOC 89,813
Functions measured 16,723
Functions complexity ≥ 15 822
Maximum complexity 670
Policy code-health-policy-v1
HEAD 6c381f655dbe041d654adf8087ab146430eb61fd
Base 4cce24528a0e5024afd78a893015dd6fce50239e
UI measurement complete

Markdown, JSON catalogs and tests are out of this table. Only app/ runtime + ui/src TS/JS count.

Most complex functions

Complexity Where
670 app/wgp.py:7164 generate_video
376 ui/src/stores/useStore.ts:4029 Async method 'startGeneration'
355 app/_launch_runtime.py:23505 _run_generation
308 app/wgp.py:12298 generate_video_tab
271 ui/src/stores/useStore.ts:8572 Async method 'loadSettingsFromOutput'
258 app/services/director/planners/short_film.py:3433 ShortFilmPlanner._plan_story_driven
257 ui/src/components/Sidebar/SceneAnimatorPanel.tsx:478 Function 'SceneAnimatorPanel'
248 app/services/director_pipeline.py:13607 _run_video_generation
245 app/services/director_pipeline.py:7712 _run_pipeline
244 ui/src/features/agent/agentActions.ts:1145 Function 'parseAction'
226 app/services/director_pipeline.py:6541 update_comic_preview
225 ui/src/features/agent/agentActions.ts:2892 Async function 'executeAgentActions'

Trend vs baseline

Metric Δ
Production LOC +102
Test LOC +108
Functions ≥ 15 +0
Maximum complexity +0

Warnings

  • production LOC increased by +102

Ratchet passed.

@IAnMove
IAnMove merged commit 631c0d4 into development Sep 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant