-
Notifications
You must be signed in to change notification settings - Fork 0
Alpha State Machine #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SCool62
wants to merge
10
commits into
main
Choose a base branch
from
feature/alpha-state-machine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
16b0671
State transitions
SCool62 1396ce2
Populate triggers with (placeholder) button bindings
SCool62 b1ea9f4
Track routing subsystem
SCool62 9a24310
Bind (placeholder) commands)
SCool62 fdb3156
Need to call the command bindings from constructor
SCool62 32883e4
Update transitions with new state machine graph
SCool62 3f223fb
Rename continuousReq to flowReq
SCool62 839ae34
Fix intake -> ready transitions
SCool62 d70a24e
Update src/main/java/frc/robot/Superstructure.java
SCool62 2f2576b
Spotless
SCool62 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package frc.robot.subsystems; | ||
|
|
||
| import edu.wpi.first.wpilibj2.command.Command; | ||
| import edu.wpi.first.wpilibj2.command.SubsystemBase; | ||
|
|
||
| // TODO | ||
| public class IntakeSubsystem extends SubsystemBase { | ||
| public Command intake() { | ||
| // TODO | ||
| return idle(); | ||
| } | ||
|
|
||
| // Can't call it idle bc idle is smthing else | ||
| public Command rest() { | ||
| // TODO | ||
| return idle(); | ||
| } | ||
|
|
||
| public Command spit() { | ||
| // TODO | ||
| return idle(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package frc.robot.subsystems; | ||
|
|
||
| import edu.wpi.first.wpilibj2.command.Command; | ||
| import edu.wpi.first.wpilibj2.command.SubsystemBase; | ||
|
|
||
| // TODO!!! | ||
| public class RoutingSubsystem extends SubsystemBase { | ||
|
|
||
| // TODO: BASE ON ACTUAL SENSOR READINGS | ||
| private boolean isFull; | ||
| private boolean isEmpty; | ||
|
|
||
| public boolean isFull() { | ||
| return isFull; | ||
| } | ||
|
|
||
| public boolean isEmpty() { | ||
| return isEmpty; | ||
| } | ||
|
|
||
| // TODO!! | ||
| public Command index() { | ||
| return this.run(() -> {}); | ||
| } | ||
|
|
||
| // Can't call it idle bc idle is smthing else | ||
| public Command rest() { | ||
| // TODO | ||
| return idle(); | ||
| } | ||
|
|
||
| public Command reverseIndex() { | ||
| // TODO | ||
| return this.run(() -> {}); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package frc.robot.subsystems; | ||
|
|
||
| import edu.wpi.first.wpilibj2.command.Command; | ||
| import edu.wpi.first.wpilibj2.command.SubsystemBase; | ||
|
|
||
| public class ShooterSubsystem extends SubsystemBase { | ||
| public Command shoot() { | ||
| return this.idle(); | ||
| } | ||
|
|
||
| public Command feed() { | ||
| return this.idle(); | ||
| } | ||
|
|
||
| public Command rest() { | ||
| return this.idle(); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i might add an isPartial or something like that for when the second beambreak is true but first is not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just done !isEmpty but ig i could do this.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!isEmpty could include full though (although i can't remember off the top of my head if that's ever relevant still)