added robot init unit test #6
Conversation
kevinclark
left a comment
kevinclark
left a comment
There was a problem hiding this comment.
Unclear this is useful yet and expect it's in progress. Some notes though.
src/test/java/frc/InitTests.java
Outdated
| } | ||
|
|
||
| @Test | ||
| private void initTest() { |
There was a problem hiding this comment.
Prefer test names that say what is expected. These are never called, so you should be excessively verbose since it's what's going to communicate intent when it fails. F.e, "robotShouldNotCombustWhenFedFrechfries()" would be a totally reasonable unit test method name.
There was a problem hiding this comment.
Also note you don't event need test in the name - you've already communicated it's a test with the annotation
There was a problem hiding this comment.
All that being said, what's your goal with this method? When does it fail? What does it tell you when it does?
There was a problem hiding this comment.
the goal here is just to make sure Robot initializes without throwing an error, mainly as a simple template for unit tests as we (hopefully) add more throughout the season
There was a problem hiding this comment.
Then I'd make it explicit with a assertDoesNotThrow. Communicates your intent and makes clear you didn't forget the assert along the way.
| "java.test.defaultConfig": "WPIlibUnitTests", | ||
| "java.compile.nullAnalysis.mode": "automatic" | ||
| "java.compile.nullAnalysis.mode": "automatic", | ||
| "wpilib.skipTests": true |
There was a problem hiding this comment.
Is this set to true on purpose?
There was a problem hiding this comment.
yes, to avoid excessive delays during deploys from running unit tests, and instead my plan was to run these tests in ci
No description provided.