-
Notifications
You must be signed in to change notification settings - Fork 0
[refactor] EmptyView 구조 정리 및 전반적인 사용 방식 개선 #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0700502
[chore] 폴더명 수정
jjwm10625 f89a30d
[refactor] 엠티뷰 configure 수정
jjwm10625 c0bebfa
[refactor] selectedInfo 엠티뷰 컴포넌트 사용하도록 수정
jjwm10625 d84d9e5
[chore] configure에 imageName 추가
jjwm10625 93d607d
[chore] configure 수정
jjwm10625 9a7b723
[chore] configure imageName 수정
jjwm10625 3344538
[refactor] FeedListView Empty 처리 로직 정리
jjwm10625 1e51728
[refactor] FeedListView 구조 및 주석 정리
jjwm10625 7ed8cfd
[chore] 피드 상단 끌어당겨서 새로고침 삭제
jjwm10625 363b802
[chore] delegate if let 방식으로 수정
jjwm10625 710e8ec
[chore] 함수형 if let으로 변경
jjwm10625 c931ba0
[refactor] 메뉴 탭 분기 로직 if-else로 개선
jjwm10625 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,8 +28,24 @@ final class SelectedInfo: UIView { | |
|
|
||
| internal let cardTopicView = CardTopicView() | ||
| internal let cardPreview = CardPreview() | ||
| private let emptyDiaryView = EmptyDiaryView() | ||
| private let diaryLockView = DiaryLockView() | ||
|
|
||
| private let emptyDiaryView: EmptyView = { | ||
| let view = EmptyView() | ||
| view.configure( | ||
| message: "작성된 일기가 없어요.\n좋은 하루 보내셨기를 바라요!", | ||
| imageName: "img_diary_empty_ios" | ||
| ) | ||
| return view | ||
| }() | ||
|
|
||
| private let diaryLockView: EmptyView = { | ||
| let view = EmptyView() | ||
| view.configure( | ||
| message: "아직 작성 가능한 시간이 아니에요.\n오늘의 일기를 작성해주세요!", | ||
| imageName: "img_diary_lock_ios" | ||
| ) | ||
| return view | ||
| }() | ||
|
Comment on lines
+32
to
+48
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM..👍 |
||
|
|
||
| private let selectedDayLabel: UILabel = { | ||
| let label = UILabel() | ||
|
|
||
67 changes: 0 additions & 67 deletions
67
HilingualPresentation/Sources/Presentation/Common/Components/HomeView/DiaryLockView.swift
This file was deleted.
Oops, something went wrong.
66 changes: 0 additions & 66 deletions
66
HilingualPresentation/Sources/Presentation/Common/Components/HomeView/EmptyDiaryView.swift
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EmptyView를 재활용하는 방향으로 개선했군요 !