Skip to content

Txm transactions support arbitrary calldata#596

Merged
GabrielMartinezRodriguez merged 3 commits intomasterfrom
gabriel/transactions-with-calldata
Apr 28, 2025
Merged

Txm transactions support arbitrary calldata#596
GabrielMartinezRodriguez merged 3 commits intomasterfrom
gabriel/transactions-with-calldata

Conversation

@GabrielMartinezRodriguez
Copy link
Contributor

@GabrielMartinezRodriguez GabrielMartinezRodriguez commented Apr 10, 2025

Linked Issues

Description

Txm support arbitrary calldata

Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
    comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently packages/core and packages/react), see here for more info.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2025

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a07492
Status:⚡️  Build in progress...

View logs

@linear
Copy link

linear bot commented Apr 10, 2025

Copy link
Contributor Author

GabrielMartinezRodriguez commented Apr 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@GabrielMartinezRodriguez GabrielMartinezRodriguez added the reviewing-1 Ready for, or undergoing first-line review label Apr 10, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez changed the title feat(txm): transactions using calldata Txm transactions support arbitrary calldata Apr 10, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from 1a4d42f to 100fc03 Compare April 13, 2025 21:31
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from cbc8c99 to d9e8574 Compare April 13, 2025 21:31
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from 100fc03 to 8d5b6fe Compare April 13, 2025 21:37
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from d9e8574 to e78858b Compare April 13, 2025 21:37
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from 8d5b6fe to ee8889a Compare April 13, 2025 21:38
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from e78858b to 0d8a825 Compare April 13, 2025 21:38
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from ee8889a to 513f974 Compare April 13, 2025 21:39
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from 0d8a825 to a604da8 Compare April 13, 2025 21:39
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from 513f974 to 2bf6dd1 Compare April 13, 2025 21:40
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from a604da8 to 6b380e7 Compare April 13, 2025 21:40
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from 2bf6dd1 to 544cb2d Compare April 13, 2025 21:42
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from 6b380e7 to 388e2f4 Compare April 13, 2025 21:42
@norswap norswap added merge-blocked Ready to merge, waiting for downstack and removed reviewing-1 Ready for, or undergoing first-line review labels Apr 24, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from 22f4cb1 to ef46a34 Compare April 24, 2025 10:03
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch 3 times, most recently from b6848f9 to 7e3bd09 Compare April 24, 2025 11:12
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from 12eeef7 to f3644b3 Compare April 28, 2025 11:08
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from 7e3bd09 to 9ba69a6 Compare April 28, 2025 11:08
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/submit-transactions-asap branch from f3644b3 to 280a889 Compare April 28, 2025 12:53
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from 9ba69a6 to a081c22 Compare April 28, 2025 12:54
Base automatically changed from gabriel/submit-transactions-asap to master April 28, 2025 12:54
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/transactions-with-calldata branch from a081c22 to 1a07492 Compare April 28, 2025 12:57
@GabrielMartinezRodriguez GabrielMartinezRodriguez merged commit 48bb0e4 into master Apr 28, 2025
2 of 4 checks passed
@GabrielMartinezRodriguez GabrielMartinezRodriguez deleted the gabriel/transactions-with-calldata branch April 28, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-blocked Ready to merge, waiting for downstack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants