Skip to content

fix(txm): returned nonce queue order#578

Merged
GabrielMartinezRodriguez merged 2 commits intomasterfrom
gabriel/fix-returned-nonce-order
Apr 13, 2025
Merged

fix(txm): returned nonce queue order#578
GabrielMartinezRodriguez merged 2 commits intomasterfrom
gabriel/fix-returned-nonce-order

Conversation

@GabrielMartinezRodriguez
Copy link
Contributor

@GabrielMartinezRodriguez GabrielMartinezRodriguez commented Apr 1, 2025

Description

Fix a bug to preserve the ascending order in the returned nonce queue

Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
    comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently packages/core and packages/react), see here for more info.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 1, 2025

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: bea47ea
Status:⚡️  Build in progress...

View logs

@aodhgan aodhgan added merge-blocked Ready to merge, waiting for downstack and removed reviewing-1 Ready for, or undergoing first-line review labels Apr 1, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-repeated-blocks branch from 295778e to 2493832 Compare April 3, 2025 11:18
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 343eab4 to b26ccdf Compare April 3, 2025 11:18
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-repeated-blocks branch from 2493832 to 1b2d737 Compare April 3, 2025 11:37
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from b26ccdf to c8f2af5 Compare April 3, 2025 11:37
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-repeated-blocks branch from 1b2d737 to 38e19fa Compare April 3, 2025 13:08
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from c8f2af5 to 23c42fd Compare April 3, 2025 13:08
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-repeated-blocks branch from 38e19fa to 00c1df8 Compare April 7, 2025 10:42
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 23c42fd to 99a3e15 Compare April 7, 2025 10:42
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-repeated-blocks branch from 00c1df8 to bc3d19e Compare April 7, 2025 11:42
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 99a3e15 to 7bfc885 Compare April 7, 2025 11:42
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-repeated-blocks branch from bc3d19e to 7d13775 Compare April 7, 2025 11:45
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 7bfc885 to b9f441a Compare April 7, 2025 11:45
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 161217c to be24f08 Compare April 10, 2025 08:51
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from be24f08 to 81ed24a Compare April 10, 2025 09:13
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 81ed24a to 694721d Compare April 10, 2025 09:56
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 694721d to 85f1522 Compare April 10, 2025 11:51
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 85f1522 to fe19633 Compare April 10, 2025 11:56
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from fe19633 to 03b78a8 Compare April 13, 2025 21:30
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 03b78a8 to f9905ee Compare April 13, 2025 21:36
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from f9905ee to 988fc7f Compare April 13, 2025 21:38
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 988fc7f to 081bd13 Compare April 13, 2025 21:39
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/fix-returned-nonce-order branch from 081bd13 to bea47ea Compare April 13, 2025 21:40
Base automatically changed from gabriel/fix-repeated-blocks to master April 13, 2025 21:40
@GabrielMartinezRodriguez GabrielMartinezRodriguez merged commit f4433cf into master Apr 13, 2025
1 of 3 checks passed
@GabrielMartinezRodriguez GabrielMartinezRodriguez deleted the gabriel/fix-returned-nonce-order branch April 13, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-blocked Ready to merge, waiting for downstack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants