Skip to content

feat: implement wallet_getCallsStatus request handler#527

Open
ultraviolet10 wants to merge 9 commits intoaritra/5792_wallet_sendCallsfrom
aritra/5792_wallet_getCallsStatus
Open

feat: implement wallet_getCallsStatus request handler#527
ultraviolet10 wants to merge 9 commits intoaritra/5792_wallet_sendCallsfrom
aritra/5792_wallet_getCallsStatus

Conversation

@ultraviolet10
Copy link
Contributor

Linked Issues

  • closes #XXX
  • closes

Description

< DESCRIPTION GOES HERE >

  • Include all relevant context (but no need to repeat the issue's content).
  • Draw attention to new, noteworthy & unintuitive elements.
Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
    comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently pacakges/core and packages/react), see here for more info.

Copy link
Contributor Author

ultraviolet10 commented Mar 14, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ultraviolet10 ultraviolet10 marked this pull request as ready for review March 14, 2025 15:23
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 14, 2025

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e1614a
Status: ✅  Deploy successful!
Preview URL: https://64cca19e.happychain.pages.dev
Branch Preview URL: https://aritra-5792-wallet-getcallss.happychain.pages.dev

View logs

@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from 6c14029 to 0fbd8ca Compare March 15, 2025 09:59
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_getCallsStatus branch from 48ef7c3 to 6a4722a Compare March 15, 2025 09:59
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from 0fbd8ca to e08e6e4 Compare March 20, 2025 11:06
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_getCallsStatus branch from 6a4722a to f637694 Compare March 20, 2025 11:06
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from e08e6e4 to e2b48e4 Compare March 24, 2025 12:15
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_getCallsStatus branch from f637694 to 6eeaa66 Compare March 24, 2025 12:15
@ultraviolet10 ultraviolet10 added the updating Updating after review label Apr 24, 2025
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_getCallsStatus branch from 6eeaa66 to f351183 Compare April 28, 2025 12:05
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from e2b48e4 to 0cd1436 Compare April 28, 2025 12:05
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_getCallsStatus branch from f351183 to e0e5403 Compare April 28, 2025 12:17
@ultraviolet10 ultraviolet10 added reviewing-1 Ready for, or undergoing first-line review and removed updating Updating after review labels Apr 28, 2025
@ultraviolet10 ultraviolet10 changed the base branch from aritra/5792_wallet_sendCalls to graphite-base/527 May 12, 2025 19:18
* @param receipts - Array of UserOperationReceipt objects or null.
* @returns WalletGetCallsStatusReturnType with formatted receipt data.
*/
export function convertUserOpReceiptToCallStatus(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sus. is this still real? should be boop?

if (!hash) {
throw new Error("Transaction hash is missing.")
}
const smartAccountClient = (await getSmartAccountClient()) as ExtendedSmartAccountClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boop! 😄

@ultraviolet10 ultraviolet10 changed the title feat: implement wallet_getCallsStatus request handler feat: implement wallet_getCallsStatus request handler May 29, 2025
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792_wallet_getCallsStatus branch from e0e5403 to 9e1614a Compare May 29, 2025 14:38
@ultraviolet10 ultraviolet10 changed the base branch from graphite-base/527 to aritra/5792_wallet_sendCalls May 29, 2025 14:38
Copy link
Contributor

@not-reed not-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened with bun lock here? maybe need to restack or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority-post-testnet reviewing-1 Ready for, or undergoing first-line review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants