feat: implement `wallet_sendCalls` request handler by ultraviolet10 · Pull Request #526 · HappyChainDevs/happychain

ultraviolet10 · 2025-03-14T14:54:49Z

Linked Issues

closes #XXX
closes

Description

Implemented support for the wallet_sendCalls method (EIP-5792) in the wallet iframe. This allows dApps to request transaction execution through a standardized interface.

Key changes:

Added a new component WalletSendCalls.tsx to render transaction confirmation UI
Implemented validation logic for wallet_sendCalls parameters
Added capability validation for supported features (currently only boopPaymaster)
Limited implementation to support only single-call batches (no atomicity)
Connected the new method to the existing boop transaction system
Updated request handlers and UI routes to support the new method

Toggle Checklist

Checklist

Basics

B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
B2. This PR is not so big that it should be split & addresses only one concern.
B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments (e.g. local,
testnet, mainnet, standalone wallet, ...).
C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

C4. I have performed a thorough self-review of my code after submitting the PR,
and have updated the code & comments accordingly.

Architecture & Documentation

D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
comments.
D3. If appropriate, the general architecture of the code is documented in a code comment or
in a Markdown document.
D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently pacakges/core and packages/react), see here for more info.

ultraviolet10 · 2025-03-14T14:55:05Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-03-15T09:59:31Z

Deploying happychain with Cloudflare Pages

Latest commit:	`9ed7446`
Status:	✅ Deploy successful!
Preview URL:	https://05e4905d.happychain.pages.dev
Branch Preview URL:	https://aritra-5792-wallet-sendcalls.happychain.pages.dev

View logs

ultraviolet10 · 2025-05-12T19:20:20Z

some code reorg is needed 😅

not-reed · 2025-05-21T17:53:17Z

apps/iframe/src/components/requests/WalletSendCalls.tsx

+} from "./common/Layout"
+import type { RequestConfirmationProps } from "./props"
+
+export function getFirstParam<T>(params: [T] | undefined): T | undefined {


Suggested change

export function getFirstParam<T>(params: [T] | undefined): T | undefined {

export function getFirstParam<T>(params: [T, ...unknown[]] | undefined): T | undefined {

makes it a tad smarter

vs currently it fails if 'params' has more than one item

should probs move this to wallet-common?

not-reed · 2025-05-21T17:53:34Z

apps/iframe/src/requests/handlers/approved.ts

            return addWatchedAsset(user.address, request.payload.params)
        }

+        case "wallet_sendCalls": {


does this need to be in injected as well?

not-reed · 2025-05-21T17:54:17Z

bun.lock

don't delete this

not-reed · 2025-05-21T17:54:23Z

bun.lockb

delete this

not-reed · 2025-05-21T17:54:50Z

demos/react/package.json

        "react": "^18.3.1",
        "react-dom": "^18.3.1",
        "sonner": "^1.7.2",
+        "vaul": "^1.1.2",


i think these changes aren't used?

removed it, was testing something w/ it :)

ultraviolet10 · 2025-05-22T13:49:21Z

apps/iframe/src/requests/utils/checks.ts

+type WalletSendCallsParams = WalletSendCallsParameters<BoopPaymasterCapability, Hex, Hex | bigint>
+
+// cf.
+export function checkedWalletSendCallsParams(params: WalletSendCallsParams | undefined): ValidWalletSendCallsRequest {


combed through this list to identify all the necessary errors to be thrown for accuracy

…ndling

…for better flexibility

ultraviolet10 mentioned this pull request Mar 14, 2025

monorepo-wide viem update #524

Merged

11 tasks

This was referenced Mar 14, 2025

feat(iframe): implement wallet_getCapabilities method #525

Open

feat: implement wallet_getCallsStatus request handler #527

Open

ultraviolet10 marked this pull request as ready for review March 14, 2025 15:23

ultraviolet10 force-pushed the aritra/5792_get_capabilities branch from fcdfc53 to 3f44845 Compare March 15, 2025 09:59

ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from 6c14029 to 0fbd8ca Compare March 15, 2025 09:59

ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from 0fbd8ca to e08e6e4 Compare March 20, 2025 11:06

ultraviolet10 force-pushed the aritra/5792_get_capabilities branch 2 times, most recently from 11ef2c8 to 7502930 Compare March 24, 2025 12:15

ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from e08e6e4 to e2b48e4 Compare March 24, 2025 12:15

ultraviolet10 added the updating Updating after review label Apr 24, 2025

ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from e2b48e4 to 0cd1436 Compare April 28, 2025 12:05

ultraviolet10 force-pushed the aritra/5792_get_capabilities branch from 7502930 to 06f22f5 Compare April 28, 2025 12:05

ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from 0cd1436 to cf1850c Compare April 28, 2025 12:17

ultraviolet10 changed the base branch from aritra/5792_get_capabilities to graphite-base/526 May 9, 2025 11:03

ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from cf1850c to cb66b67 Compare May 12, 2025 19:19

ultraviolet10 force-pushed the graphite-base/526 branch from d1589ca to af3fd5b Compare May 12, 2025 19:19

ultraviolet10 changed the base branch from graphite-base/526 to aritra/5792_get_capabilities May 12, 2025 19:19

ultraviolet10 added reviewing-1 Ready for, or undergoing first-line review and removed updating Updating after review labels May 12, 2025

ultraviolet10 added the priority-post-testnet label May 19, 2025

not-reed requested changes May 21, 2025

View reviewed changes

ultraviolet10 changed the base branch from aritra/5792_get_capabilities to graphite-base/526 May 22, 2025 12:42

ultraviolet10 changed the title ~~feat: implement wallet_sendCalls request handler~~ feat: implement wallet_sendCalls request handler May 22, 2025

ultraviolet10 force-pushed the graphite-base/526 branch from af3fd5b to dfe3f5a Compare May 22, 2025 13:42

ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from cb66b67 to a8d3bf0 Compare May 22, 2025 13:42

ultraviolet10 changed the base branch from graphite-base/526 to aritra/5792_get_capabilities May 22, 2025 13:42

ultraviolet10 commented May 22, 2025

View reviewed changes

ultraviolet10 changed the base branch from aritra/5792_get_capabilities to graphite-base/526 May 29, 2025 07:09

ultraviolet10 added 17 commits May 29, 2025 12:45

feat: app demo scaffold

e10d0ec

update viem package, add new component to demo

2c668cb

clean up demo scaffold

8113f57

feat: app demo scaffold

b95844d

clean up demo scaffold

1b6727a

feat(iframe): implement wallet_getCapabilities method

574dbf6

fix: import reuse + format

0a16d82

restack

9d458c5

feat(iframe): implement wallet_getCapabilities method

15c1d56

fix: import reuse + format

cfed326

feat: implement wallet_sendCalls request handler

9467f75

fix: package updates params type for send calls

f4acede

boop refresh

c499ba8

add WalletSendCalls component and enhance wallet_sendCalls request ha…

13aa934

…ndling

minimal refactor of request popup

1af7203

refactor: remove bun.lockb and update WalletSendCalls parameter type …

72bef8d

…for better flexibility

minor refactors for restack

9ed7446

ultraviolet10 force-pushed the graphite-base/526 branch from dfe3f5a to be88f94 Compare May 29, 2025 07:34

ultraviolet10 force-pushed the aritra/5792_wallet_sendCalls branch from a8d3bf0 to 9ed7446 Compare May 29, 2025 07:34

ultraviolet10 changed the base branch from graphite-base/526 to aritra/5792_get_capabilities May 29, 2025 07:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement `wallet_sendCalls` request handler#526

feat: implement `wallet_sendCalls` request handler#526
ultraviolet10 wants to merge 17 commits intoaritra/5792_get_capabilitiesfrom
aritra/5792_wallet_sendCalls

ultraviolet10 commented Mar 14, 2025 •

edited

Loading

Uh oh!

ultraviolet10 commented Mar 14, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Mar 15, 2025 •

edited

Loading

Uh oh!

ultraviolet10 commented May 12, 2025

Uh oh!

not-reed May 21, 2025

Uh oh!

ultraviolet10 May 22, 2025

Uh oh!

not-reed May 21, 2025

Uh oh!

not-reed May 21, 2025

Uh oh!

not-reed May 21, 2025

Uh oh!

not-reed May 21, 2025

Uh oh!

ultraviolet10 May 22, 2025

Uh oh!

ultraviolet10 May 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	export function getFirstParam<T>(params: [T] \| undefined): T \| undefined {
	export function getFirstParam<T>(params: [T, ...unknown[]] \| undefined): T \| undefined {

Conversation

ultraviolet10 commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked Issues

Description

Checklist

Basics

Correctness

Architecture & Documentation

Uh oh!

ultraviolet10 commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying happychain with Cloudflare Pages

Uh oh!

ultraviolet10 commented May 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ultraviolet10 commented Mar 14, 2025 •

edited

Loading

ultraviolet10 commented Mar 14, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 15, 2025 •

edited

Loading