Deploy randomness service by GabrielMartinezRodriguez · Pull Request #416 · HappyChainDevs/happychain

GabrielMartinezRodriguez · 2025-02-05T14:03:44Z

Links

The randomness service is already deployed and functioning with this contract: https://happy-testnet-sepolia.explorer.caldera.xyz/address/0xf4822fC7CB2ec69A5f9D4b5d4a59B949eFfa8311?tab=txs

Description

This PR adds the necessary changes to deploy the randomness service:

The changes include:

Added a GitHub Action to deploy the randomness service
Compiled migrations to be included in the bundler
Increased the tip so that the block is regenerated even if the sequencer already has a generated block (reference)
Increased the polling interval so that the reveal transaction lands exactly in the next block

Toggle Checklist

Checklist

Basics

B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
B2. This PR is not so big that it should be split & addresses only one concern.
B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments (e.g. local, testnet, mainnet, standalone wallet, ...).
C3. I have manually tested my changes & connected features.
C4. I have performed a thorough self-review of my code after submitting the PR, and have updated the code & comments accordingly.

Architecture & Documentation

D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries, (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code comments.
D3. If appropriate, the general architecture of the code is documented in a code comment or in a Markdown document.

cloudflare-workers-and-pages · 2025-02-05T14:03:46Z

Deploying happychain with Cloudflare Pages

Latest commit:	`7b83dfb`
Status:	✅ Deploy successful!
Preview URL:	https://df3110da.happychain.pages.dev
Branch Preview URL:	https://gabriel-deploy-randomness.happychain.pages.dev

View logs

GabrielMartinezRodriguez · 2025-02-05T14:04:19Z

Deploy randomness service #416 : 2 dependent PRs (#434 , #441 ) 👈 (View in Graphite)
Add config contract #404
Randomness service: Improve performance and reliability #372
Add transaction submission failure hook and error handling #366
Increase default RPC timeout to 2000ms #365
Add configurable HTTP polling interval for block monitoring #362
Force initialization before using the TXM #361
Script to monitor randomness service #325
Script to easily launch the randomness service locally #324
Submit drand numbers #318
Random oracle contracts #307
Only prune finalized randomness entries #305
Add NewBlock hook #304
Refactors the randomness service to be able to process pending commitments #303
Add SQLite persistence to randomness service #300
Txm no longer receives Viem objects #298 : 1 other dependent PR (#299 )
Add flush mechanism #289 : 1 other dependent PR (#297 )
Allow run multiple txm simultaneously within the same service #285
Added docs for txm #272
Mutex in tx monitor #264
Purge transactions #232
Txm hooks #229
Use kysely instead of mikro-orm #250
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

.github/workflows/deploy-randomness.yml

packages/txm/tsconfig.json

norswap · 2025-02-09T23:09:04Z

packages/txm/lib/TxMonitor.ts

            const inAirAttempts = transaction.getInAirAttempts()

+            console.log("In air attempts", inAirAttempts.map((a) => a.nonce))
+


Are those log statements left here on purpose?

I removed them. I was adding those logs to debug in production. I left one for now in BlockMonitor because I'm trying to understand a behavior in production

Finally, I removed that comment from this branch, and I'm trying to debug the deployed randomness by deploying from a more specific branch

norswap · 2025-02-09T23:09:33Z

packages/txm/lib/BlockMonitor.ts

    }

    private onNewBlock(block: LatestBlock) {
+        console.log("onNewBlock", JSON.stringify(block, bigIntReplacer, 2))


Left on purpose? What's the plan?

I removed them. I was adding those logs to debug in production. I left one for now in BlockMonitor because I'm trying to understand a behavior in production

Finally, I removed that comment from this branch, and I'm trying to debug the deployed randomness by deploying from a more specific branch

Can add the logger in now.

Finally, we don't have a console log here

.github/workflows/deploy-randomness.yml

GabrielMartinezRodriguez marked this pull request as ready for review February 5, 2025 14:04

GabrielMartinezRodriguez marked this pull request as draft February 5, 2025 14:04

norswap added the draft Not ready for review label Feb 5, 2025

GabrielMartinezRodriguez added reviewing-1 Ready for, or undergoing first-line review and removed draft Not ready for review labels Feb 6, 2025

GabrielMartinezRodriguez self-assigned this Feb 6, 2025

GabrielMartinezRodriguez marked this pull request as ready for review February 6, 2025 16:16

GabrielMartinezRodriguez changed the title ~~feat: add randomness deployment workflow~~ Deploy randomness service Feb 6, 2025

aodhgan reviewed Feb 7, 2025

View reviewed changes

.github/workflows/deploy-randomness.yml Show resolved Hide resolved

norswap reviewed Feb 9, 2025

View reviewed changes

norswap added question Something has to be cleared up after review and removed reviewing-1 Ready for, or undergoing first-line review labels Feb 9, 2025

GabrielMartinezRodriguez force-pushed the gabriel/config-contract branch from 8af1689 to 2d694da Compare February 11, 2025 14:28

GabrielMartinezRodriguez force-pushed the gabriel/deploy-randomness branch from dfdae27 to d25fb79 Compare February 11, 2025 14:28

GabrielMartinezRodriguez added 23 commits February 17, 2025 14:09

chore: deploy randomness

161dd0c

chore: deploy randomness

6982226

chore: deploy randomness

eaaf485

chore: deploy randomness

3dde6bb

chore: deploy randomness

edad8d6

chore: deploy randomness

206d94a

chore: deploy randomness

4d2eba8

fix(randomness): increased gas limit and tip

631afbe

chore(randomness): increased polling interval

f428bc5

chore(randomness): added console.log for monitor txm stuck

32fad39

chore(randomness): changed monitoring logs

8afb643

chore(randomness): changed monitoring logs

2c7ba68

chore(randomness): changed monitoring logs

dc7f36a

chore(txm): remove console log

3e61267

chore(randomness): change identation

c4489a3

chore(txm): new block received

859ef94

chore(txm): added debug log

b7dab0a

chore(txm): change identation again

ac89a7d

chore(randomness): added comment

70365db

chore(randomness): removed console.log and not deploy on pr

1dec8f1

chore(randomness): removed comment

83c5c68

chore(randomness): remove console.log

ea10681

chore(randomness): pr review

dabb31d

GabrielMartinezRodriguez force-pushed the gabriel/deploy-randomness branch from 4f3b431 to dabb31d Compare February 17, 2025 13:12

chore: format

7b83dfb

GabrielMartinezRodriguez merged commit ad1a832 into master Feb 17, 2025
3 checks passed

GabrielMartinezRodriguez deleted the gabriel/deploy-randomness branch February 17, 2025 13:26

GabrielMartinezRodriguez mentioned this pull request Feb 25, 2025

Fix: random() reverts once every 3 blocks #458

Merged

11 tasks

linear bot mentioned this pull request Mar 12, 2025

Deployed Random and AdressBook into Happy Sepolia #515

Merged

11 tasks

linear bot mentioned this pull request Mar 27, 2025

Dynamic priority fee #570

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploy randomness service#416

Deploy randomness service#416
GabrielMartinezRodriguez merged 38 commits intomasterfrom
gabriel/deploy-randomness

GabrielMartinezRodriguez commented Feb 5, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Feb 5, 2025 •

edited

Loading

Uh oh!

GabrielMartinezRodriguez commented Feb 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

norswap Feb 9, 2025

Uh oh!

GabrielMartinezRodriguez Feb 12, 2025

Uh oh!

GabrielMartinezRodriguez Feb 12, 2025

Uh oh!

norswap Feb 9, 2025

Uh oh!

GabrielMartinezRodriguez Feb 12, 2025

Uh oh!

GabrielMartinezRodriguez Feb 12, 2025

Uh oh!

norswap Feb 15, 2025

Uh oh!

GabrielMartinezRodriguez Feb 17, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		const inAirAttempts = transaction.getInAirAttempts()

		console.log("In air attempts", inAirAttempts.map((a) => a.nonce))

Conversation

GabrielMartinezRodriguez commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Links

Description

Checklist

Basics

Correctness

Architecture & Documentation

Uh oh!

cloudflare-workers-and-pages bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying happychain with Cloudflare Pages

Uh oh!

GabrielMartinezRodriguez commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GabrielMartinezRodriguez commented Feb 5, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 5, 2025 •

edited

Loading

GabrielMartinezRodriguez commented Feb 5, 2025 •

edited

Loading