Add transaction submission failure hook and error handling#366
Add transaction submission failure hook and error handling#366GabrielMartinezRodriguez merged 4 commits intomasterfrom
Conversation
Deploying happychain with
|
| Latest commit: |
2c9bf41
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd973ade.happychain.pages.dev |
| Branch Preview URL: | https://gabriel-txm-submission-faile.happychain.pages.dev |
HAPPY-282 Hook to notify the library user about issues before submitting their transactions.
We want to notify users about potential issues that may occur before submitting their transactions, such as problems encountered when simulating a transaction. These issues could result in the transaction remaining indefinitely in our database while attempting to be included, without notifying the user. Another good idea would be to implement a system that allows users to modify the parameters of such transactions to resolve these issues, for example, by changing the call data. Additionally, it should also be possible for users to remove these transactions. |
8e4376e to
a7c5995
Compare
8cfe729 to
f8117b9
Compare
a7c5995 to
f238ce6
Compare
f8117b9 to
a98fbb3
Compare
f238ce6 to
6ddafa5
Compare
a98fbb3 to
82a0cb6
Compare
6ddafa5 to
352683b
Compare
82a0cb6 to
98067ed
Compare
352683b to
0303189
Compare
0303189 to
6123c34
Compare
70e6dc4 to
55a5c0a
Compare
6123c34 to
440728c
Compare
55a5c0a to
6749747
Compare
440728c to
877ca68
Compare
6749747 to
f5a61b6
Compare
| eventBus.emit(Topics.TransactionSubmissionFailed, { | ||
| transaction, | ||
| description: submissionResult.error.description, | ||
| }) |
There was a problem hiding this comment.
Seems like a good idea to also pass the cause from the AttemptSubmissionErrorCause enum (and export that publicly) so that might enable finer-grained reaction to this without needing to parse the description.
877ca68 to
fab80c3
Compare
f5a61b6 to
05dc512
Compare
fab80c3 to
4722d38
Compare
05dc512 to
b9ba93f
Compare

Linked Issues
Description
TransactionSubmissionFailedhook to capture submission failuresToggle Checklist
Checklist
Basics
norswap/build-system-caching).Correctness
C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments.
C3. I have manually tested my changes & connected features.
C4. I have performed a thorough self-review of my code after submitting the PR.
Architecture & Documentation