refactor run scripts to a single macros with includes #5538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
jhendersonHDF,
derobins,
lrknox,
fortnern and
qkoziol
as code owners
byrnHDF
requested review from
vchoi-hdfgroup,
bmribler and
glennsong09
as code owners
mattjala
reviewed
May 21, 2025
mattjala
reviewed
May 21, 2025
mattjala
reviewed
May 21, 2025
mattjala
reviewed
May 21, 2025
|
One thing to keep in mind that the runTest and runExecute(better name?) files execute in a private environment from all the other macro and test files. While possible to include other files it makes the code for these test macros more difficult. |
mattjala
reviewed
May 22, 2025
mattjala
previously approved these changes
May 22, 2025
mattjala
approved these changes
May 23, 2025
lrknox
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5485
Fixes #5484