Skip to content

Fix incorrect test file masking #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mattjala
Copy link
Contributor

  • Fix the reference file not being masked

  • Fix the output comparison using the unmasked reference file

@mattjala mattjala added the Priority - 1. High These are important issues that should be resolved in the next release label May 21, 2025
@mattjala mattjala requested review from lrknox and derobins as code owners May 21, 2025 15:35
@mattjala mattjala added the Component - Testing Code in test or testpar directories, GitHub workflows label May 21, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in HDF5 - TRIAGE & TRACK May 21, 2025
@byrnHDF
Copy link
Contributor

byrnHDF commented May 21, 2025

Can we wait on this till after #5538 and #5540 are in

@mattjala mattjala marked this pull request as draft May 21, 2025 16:26
@nbagha1 nbagha1 moved this from To be triaged to In progress in HDF5 - TRIAGE & TRACK May 23, 2025
@mattjala mattjala closed this May 29, 2025
@mattjala mattjala deleted the test_mask_fix branch May 29, 2025 19:15
@github-project-automation github-project-automation bot moved this from In progress to Done in HDF5 - TRIAGE & TRACK May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 1. High These are important issues that should be resolved in the next release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants