Re-enable PSNR-B metric in Image Comparison Tool#46
Re-enable PSNR-B metric in Image Comparison Tool#46diksha78dev wants to merge 3 commits intoGooichand:masterfrom
Conversation
…ic Docker setup; add macOS docker-compose file
…m-specific Docker setup; add macOS docker-compose file" This reverts commit c6338c4.
…erify metrics table
|
✅ Looks good! However, PR #44 also modifies To avoid merge conflicts:Option A: We merge this first (preferred - it's better documented) Which would you prefer? |
|
I agree — let’s merge PR #44 first since it’s better documented. |
|
@diksha78dev #44 has some issue afte that i willl merged |
|
📢 Important: OSCG-26 Communication Update Body: Nexfellow is now our primary communication platform for OSCG-26. 👉 Important announcement - Please like and follow: This post contains critical project updates and information. Thank you for your contributions! 🙏 |
|
✅ LGTM - Ready to Merge Great work fixing the PSNR-B metric! The sewar library bug was resolved in v0.4.4 (July 2020), so it's safe to re-enable this metric. Changes look good:
This restores full functionality to the Image Comparison Tool. Approved for merge! 🎯 |
|
Summary
Re-enables the PSNR-B metric in
gui/comparison.py. The metric was previously disabled due to a bug in sewar library that has been fixed since sewar v0.4.4 (July 2020).Changes
sewar.psnrb()callTesting
✅ All 13+ metrics compute without errors
✅ PSNR-B correctly displays as "9.48" in table row 6
✅ No commented-out code remaining
✅ Verified with test_psnrb.py
Related