Skip to content

added new pnsr formula#44

Merged
Gooichand merged 1 commit intoGooichand:masterfrom
magic-peach:add/pnsr-formula
Feb 28, 2026
Merged

added new pnsr formula#44
Gooichand merged 1 commit intoGooichand:masterfrom
magic-peach:add/pnsr-formula

Conversation

@magic-peach
Copy link
Contributor

created a new pnsr formula
fixes #11

@Gooichand
Copy link
Owner

⚠️ Misleading Title + Merge Conflict

Thanks for working on Issue #11! However:

Problem 1: Title says "added new pnsr formula" but you just refactored the existing PSNR (changed 20*log10 to 10*log10 which is mathematically equivalent). No new formula was added.

Problem 2: This conflicts with PR #46 - both modify comparison.py. PR #46 should merge first (it's better documented), then you'll need to rebase.

Questions:

  1. What was the bug in Issue PSNR formula in ComparisonWidget is mathematically incorrect #11? The math looks correct in both versions.
  2. Did you mean to add a different PSNR variant (PSNR-HVS, PSNR-HMA)?

Please clarify and update the title to "Refactor PSNR calculation" if it's just code cleanup. 👍

@Gooichand Gooichand added bug Something isn't working OSCG26 Easy labels Feb 12, 2026
@Gooichand Gooichand merged commit 620d23b into Gooichand:master Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Easy OSCG26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PSNR formula in ComparisonWidget is mathematically incorrect

2 participants