-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marked customer_name field as optional for interconnect resource #11640
Merged
shuyama1
merged 10 commits into
GoogleCloudPlatform:main
from
abhijeetkjha-google:bugFix-361094483
Sep 24, 2024
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0d61f5c
Marked customer_name field as optional
abhijeetkjha-google 616214f
removed customer_name field from the example
abhijeetkjha-google c4fa4cc
Added create test for cross cloud interconnect
abhijeetkjha-google ac24639
Added example
abhijeetkjha-google 55f7d64
Merge branch 'GoogleCloudPlatform:main' into bugFix-361094483
abhijeetkjha-google d0b54e4
removed create test as no testing location is provided yet
abhijeetkjha-google 73e8056
lint issues
abhijeetkjha-google 0a2a7f5
Updated description for customerName field
abhijeetkjha-google 77cd76a
Updated description for customerName field - 2
abhijeetkjha-google fae33ec
Updated description for location field
abhijeetkjha-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
mmv1/templates/terraform/examples/compute_interconnect_cross_cloud_basic.tf.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
data "google_project" "project" {} | ||
|
||
resource "google_compute_interconnect" "<%= ctx[:primary_resource_id] %>" { | ||
name = "<%= ctx[:vars]['interconnect_name'] %>" | ||
description = "description" | ||
noc_contact_email = "[email protected]" | ||
admin_enabled = true | ||
link_type = "LINK_TYPE_ETHERNET_100G_LR" | ||
requested_link_count = 5 | ||
interconnect_type = "DEDICATED" | ||
remote_location = "http://www.googleapis.com/compute/v1/projects/project-name/global/interconnectRemoteLocations/interconnect-remote-location" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the description of this field to clarify when this field is required and when it is not? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.