Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked customer_name field as optional for interconnect resource #11640

Merged
7 changes: 6 additions & 1 deletion mmv1/products/compute/Interconnect.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ examples:
primary_resource_id: 'example-interconnect'
vars:
interconnect_name: 'example-interconnect'
- !ruby/object:Provider::Terraform::Examples
name: 'compute_interconnect_cross_cloud_basic'
skip_docs: true
primary_resource_id: 'example-interconnect'
vars:
interconnect_name: 'example-interconnect'
custom_code: !ruby/object:Provider::Terraform::CustomCode
constants: templates/terraform/constants/interconnect.go.erb
properties:
Expand Down Expand Up @@ -145,7 +151,6 @@ properties:
Customer name, to put in the Letter of Authorization as the party authorized to request a
crossconnect.
immutable: true
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the description of this field to clarify when this field is required and when it is not? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- !ruby/object:Api::Type::Enum
name: 'operationalStatus'
description: |
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
data "google_project" "project" {}

resource "google_compute_interconnect" "<%= ctx[:primary_resource_id] %>" {
name = "<%= ctx[:vars]['interconnect_name'] %>"
description = "description"
noc_contact_email = "[email protected]"
admin_enabled = true
link_type = "LINK_TYPE_ETHERNET_100G_LR"
requested_link_count = 5
interconnect_type = "DEDICATED"
remote_location = "http://www.googleapis.com/compute/v1/projects/project-name/global/interconnectRemoteLocations/interconnect-remote-location"
}
Loading