Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marked customer_name field as optional for interconnect resource #11640

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Marked customer_name field as optional for interconnect resource #11640

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d61f5c
Marked customer_name field as optional
abhijeetkjha-google Sep 5, 2024
616214f
removed customer_name field from the example
abhijeetkjha-google Sep 6, 2024
c4fa4cc
Added create test for cross cloud interconnect
abhijeetkjha-google Sep 13, 2024
ac24639
Added example
abhijeetkjha-google Sep 13, 2024
55f7d64
Merge branch 'GoogleCloudPlatform:main' into bugFix-361094483
abhijeetkjha-google Sep 19, 2024
d0b54e4
removed create test as no testing location is provided yet
abhijeetkjha-google Sep 19, 2024
73e8056
lint issues
abhijeetkjha-google Sep 19, 2024
0a2a7f5
Updated description for customerName field
abhijeetkjha-google Sep 23, 2024
77cd76a
Updated description for customerName field - 2
abhijeetkjha-google Sep 23, 2024
fae33ec
Updated description for location field
abhijeetkjha-google Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mmv1/products/compute/Interconnect.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ properties:
name: 'location'
description: |
URL of the InterconnectLocation object that represents where this connection is to be provisioned.
Specifies the location inside Google's Networks, should not be passed in case of cross-cloud interconnect.
resource: 'InterconnectLocations'
imports: 'selfLink'
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is making location optional in this resource intended? Sorry, I'm not fully understand what remote_location field is. Is location field not needed for resource creation in some cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Incase of cross_cloud interconnect we don't need to specify location field as location field implies for google owned location, Incase of cross_cloud interconnect we have to replace it with remote_location field.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Would you mind also clarifying it in the description of the field? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

immutable: true
- !ruby/object:Api::Type::Enum
name: 'linkType'
Expand Down Expand Up @@ -143,9 +143,9 @@ properties:
name: 'customerName'
description: |
Customer name, to put in the Letter of Authorization as the party authorized to request a
crossconnect.
crossconnect. This field is required for Dedicated and Partner Interconnect, should not be specified
for cross-cloud interconnect.
immutable: true
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the description of this field to clarify when this field is required and when it is not? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- !ruby/object:Api::Type::Enum
name: 'operationalStatus'
description: |
Expand Down
Loading