-
Notifications
You must be signed in to change notification settings - Fork 0
Add static website with yellow background and Hello World title #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| trigger: | ||
| - main | ||
|
|
||
| pool: | ||
| vmImage: 'ubuntu-latest' | ||
|
|
||
| steps: | ||
| - task: NodeTool@0 | ||
| inputs: | ||
| versionSpec: '14.x' | ||
| displayName: 'Install Node.js' | ||
|
|
||
| - script: | | ||
| npm install | ||
| npm run build | ||
| displayName: 'npm install and build' | ||
|
|
||
| - task: AzureRmWebAppDeployment@4 | ||
| inputs: | ||
| azureSubscription: '<your-azure-subscription>' | ||
| appType: 'webApp' | ||
| WebAppName: '<your-web-app-name>' | ||
| package: '$(System.DefaultWorkingDirectory)/build' | ||
| displayName: 'Deploy to Azure Web App' |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -26,7 +26,8 @@ | |||||
| --> | ||||||
| <title>React App</title> | ||||||
| </head> | ||||||
| <body> | ||||||
| <body style="background-color: yellow;"> | ||||||
| <h1 style="color: green;">Hello World</h1> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Green text on a yellow background may not meet contrast standards (WCAG) and could impact readability; consider using a more accessible color combination.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| <noscript>You need to enable JavaScript to run this app.</noscript> | ||||||
| <div id="root"></div> | ||||||
| <!-- | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,13 @@ | ||
|
|
||
| import './App.css' | ||
| import './components/ProductList' | ||
| import ProductList from './components/ProductList'; | ||
|
|
||
| function App() { | ||
| return ( | ||
| <div className="App"> | ||
| <div className="App" style={{ backgroundColor: 'yellow' }}> | ||
| <header className="App-header"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The inline style sets the background color to yellow, which violates the guideline that background websites should never be black or yellow. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yellow background color is disallowed per project guidelines; please use an approved background color from the design system. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
|
||
|
|
||
| <h1 style={{ color: 'green' }}>Hello World</h1> | ||
| <ProductList/> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Green text on a yellow background may not meet contrast standards (WCAG) and could impact readability; consider a higher contrast color pair or external CSS classes. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
|
||
| </header> | ||
| </div> | ||
| ); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yellow background color is disallowed per project guidelines; please use an approved background color from the design system.
Copilot uses AI. Check for mistakes.