-
Notifications
You must be signed in to change notification settings - Fork 0
Add static website with yellow background and Hello World title #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Related to #152 Add a title "Hello World" and set the background color to yellow in the static website. * **nodejs/axios/reactapp/public/index.html** - Add inline CSS to set the background color to yellow. - Add a `<h1>` tag with the text "Hello World" and set its color to green. * **nodejs/axios/reactapp/src/App.js** - Add inline CSS to set the background color to yellow in the `App` component. - Add a `<h1>` tag with the text "Hello World" and set its color to green. * **nodejs/axios/reactapp/azure-pipelines.yml** - Add a new file to configure Azure hosting. - Define the pipeline to build and deploy the React app to Azure. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/GitHub-BR-Work/code-examples/issues/152?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a "Hello World" heading and applies a yellow background to both the React app and the static HTML, and introduces an Azure Pipelines configuration for build and deployment.
- Inline CSS updates in
App.js
andindex.html
for background color and heading text. - New
azure-pipelines.yml
defining Node.js build and Azure Web App deployment steps.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
nodejs/axios/reactapp/src/App.js | Added inline CSS for yellow background and <h1> "Hello World". |
nodejs/axios/reactapp/public/index.html | Added inline CSS for yellow background and <h1> "Hello World". |
nodejs/axios/reactapp/azure-pipelines.yml | New pipeline to install, build, and deploy the React app to Azure. |
<header className="App-header"> | ||
|
||
|
||
<h1 style={{ color: 'green' }}>Hello World</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Green text on a yellow background may not meet contrast standards (WCAG) and could impact readability; consider a higher contrast color pair or external CSS classes.
Copilot uses AI. Check for mistakes.
@@ -26,7 +26,8 @@ | |||
--> | |||
<title>React App</title> | |||
</head> | |||
<body> | |||
<body style="background-color: yellow;"> | |||
<h1 style="color: green;">Hello World</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Green text on a yellow background may not meet contrast standards (WCAG) and could impact readability; consider using a more accessible color combination.
<h1 style="color: green;">Hello World</h1> | |
<h1 style="color: black;">Hello World</h1> |
Copilot uses AI. Check for mistakes.
import './App.css' | ||
import './components/ProductList' | ||
import ProductList from './components/ProductList'; | ||
|
||
function App() { | ||
return ( | ||
<div className="App"> | ||
<div className="App" style={{ backgroundColor: 'yellow' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yellow background color is disallowed per project guidelines; please use an approved background color from the design system.
Copilot uses AI. Check for mistakes.
@@ -26,7 +26,8 @@ | |||
--> | |||
<title>React App</title> | |||
</head> | |||
<body> | |||
<body style="background-color: yellow;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yellow background color is disallowed per project guidelines; please use an approved background color from the design system.
Copilot uses AI. Check for mistakes.
Related to #152
Add a title "Hello World" and set the background color to yellow in the static website.
nodejs/axios/reactapp/public/index.html
<h1>
tag with the text "Hello World" and set its color to green.nodejs/axios/reactapp/src/App.js
App
component.<h1>
tag with the text "Hello World" and set its color to green.nodejs/axios/reactapp/azure-pipelines.yml
For more details, open the Copilot Workspace session.