feat(modpacks): restore support for ftb modpacks, and fetch official curseforge api key #149
Check failed
There are 11 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🔴 | 4f29667 | feat(ftb): restore ftb pack support | Sign-off not found |
| 🔴 | 6b6ee82 | feat(ftb): add neoforge support to ftb | Sign-off not found |
| 🔴 | 52eda41 | feat(ftb): add metacache directory for ftb packs | Sign-off not found |
| 🔴 | 25df6db | feat(curseforge): allow fetching official api key | Sign-off not found |
| 🔴 | f5d8a62 | feat: allow curseforge to appear on new instance p... | Sign-off not found |
| 🔴 | 1f16751 | chore: remove prism's api key | Sign-off not found |
| 🔴 | 90d80ae | chore: remove (now) incorrect message | Sign-off not found |
| 🔴 | 32bc7af | fix(ftb): use QIcon instead of a non-existent getT... | Sign-off not found |
| 🔴 | 2651a8c | fix(ftb): replace missing methods with their alter... | Sign-off not found |
| 🔴 | 668a805 | fix: fix closure syntax and change the variable ty... | Sign-off not found |
| 🔴 | 762610f | fix(ftb): change the response variable type | Sign-off not found |
| 🟢 | 57ef1e1 | chore(flame): remove unnecessary qt5 compatibility... | Valid sign-off found |
| 🟢 | 5e93fb1 | fix(flame): add missing return statements | Valid sign-off found |
| 🟢 | eafda60 | refactor(flame): log API key in auth credentials c... | Valid sign-off found |
| 🟢 | 7c3c2dd | style: replace include guard with pragma once | Valid sign-off found |
| 🟢 | bdbeeca | feat(flame): move API key fetching to setup wizard | Valid sign-off found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~16 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin pack-apis