feat(modpacks): restore support for ftb modpacks, and fetch official curseforge api key #149
Merged
notwindstone merged 16 commits intoFreesmTeam:developfrom Feb 15, 2026
Merged
Conversation
Based upon the implementation by @evan-goode in FJord, without the popup on first launch.
Remove the Prism Launcher CurseForge key, as we have access to the official one.
Removes the message above CurseForge modpacks as manually downloading mods is not required with the official API.
so5iso4ka
requested review from
notwindstone,
s0me1newithhand7s and
so5iso4ka
s0me1newithhand7s
requested changes
Feb 12, 2026
Member
s0me1newithhand7s
left a comment
s0me1newithhand7s
left a comment
There was a problem hiding this comment.
since all builds are failed i recommend to convert this PR to draft
ty
Member
|
@LunaisLazier @so5iso4ka @s0me1newithhand7s could you review my changes? launcher is building now |
Member
are we deadass it worked here though 
|
Member
|
tested on windows 10, everything works |
Contributor
Author
|
So the api key shows in settings? |
Member
|
@LunaisLazier yes |
notwindstone
approved these changes
Feb 12, 2026
Member
|
cachix is a bitch ignore this pls idc about cachix cache since garnix ci is better |
so5iso4ka
requested changes
Feb 13, 2026
launcher/net/FetchFlameAPIKey.cpp
Outdated
|
|
||
| const auto& keyByteArray = block.mid(startIndex, finalIndex - startIndex); | ||
| m_result = QString{ keyByteArray }; | ||
| qDebug() << "Fetched Flame API key: " << m_result; |
Member
There was a problem hiding this comment.
I think it's worth using qCDebug(authCredentials()) here.
|
|
||
| const auto& block = qUncompress(res); | ||
| if (block.isEmpty()) { | ||
| emitFailed("Couldn't decompress Curseforge app data."); |
Member
There was a problem hiding this comment.
missing return after emitFailed()
| const QByteArray preceding{ precedingString }; | ||
| const auto& precedingIndex = block.indexOf(preceding); | ||
| if (precedingIndex == -1) { | ||
| emitFailed(QString("Couldn't find string '%1'.").arg(precedingString)); |
| const auto& startIndex = precedingIndex + preceding.size(); | ||
| const auto& finalIndex = block.indexOf(QByteArray{ "\"" }, startIndex); | ||
| if (finalIndex == -1) { | ||
| emitFailed("Couldn't find closing \" for cfCoreApiKey value."); |
launcher/net/FetchFlameAPIKey.cpp
Outdated
| #endif | ||
| this, [this](QNetworkReply::NetworkError error) { | ||
| qCritical() << "Network error: " << error; | ||
| emitFailed(m_reply->errorString()); |
as it is no longer supported Signed-off-by: so5iso4ka <so5iso4ka@icloud.com>
Signed-off-by: so5iso4ka <so5iso4ka@icloud.com>
Signed-off-by: so5iso4ka <so5iso4ka@icloud.com>
Signed-off-by: so5iso4ka <so5iso4ka@icloud.com>
Signed-off-by: so5iso4ka <so5iso4ka@icloud.com>
so5iso4ka
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.