Skip to content

tds_check_column_extra: Skip size check for BLOBs. #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ucko wants to merge 1 commit into from
Closed

tds_check_column_extra: Skip size check for BLOBs. #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/tds/tds_checks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,15 @@ tds_check_column_extra(const TDSCOLUMN * column)
assert(varint_ok);

assert(!is_numeric_type(column->column_type));
assert(column->column_cur_size <= column->column_size);
if (!is_blob_type(column->column_type)) {
/*
* Skip for BLOBs, whose reported maximum may have
* been merely nominal, and doesn't really matter
* because their storage is generally allocated
* separately, based on actual result sizes.
*/
assert(column->column_cur_size <= column->column_size);
}

/* check size of fixed type correct */
size = tds_get_size_by_type(column->column_type);
Expand Down