tds_check_column_extra: Skip size check for BLOBs. #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let column_size exceed column_cur_size for BLOBs, whose reported maximum may have been merely nominal, and doesn't really matter because their storage is generally allocated separately, based on actual result sizes. Signed-off-by: Aaron M. Ucko <[email protected]>
Contributor
|
I suppose server should not report a size lesser than the returned data (that is should consider TEXTSIZE setting). But yes, currently code won't have any issue with this and maybe is not respected for data sent to the server. Some tests here are maybe too strict. On the other side these tests should not be compiled in production and so they should not trigger and I don't see any failure during testing. Did you manage to reproduce? |
Contributor
Author
|
I didn't directly encounter a situation where this change helped, but AFAICT it did in fact originally compensate for a server-side bug (probably in an OpenServer instance, quite possibly in instance-specific code) that has since been fixed. Withdrawing accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let column_size exceed column_cur_size for BLOBs, whose reported maximum may have been merely nominal, and doesn't really matter because their storage is generally allocated separately, based on actual result sizes.
Split from #555.