Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Re-design: prerequisites #4743

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Nov 7, 2024

extract the features mixin into the account store, extract the permis…sionsMixin into a composable, fix webpack devtool source mapping

Description

  • the features mixin is cumbersome to use and bloats each component it's added to and cannot be used in vuex stores
  • the persmissions mixin is not usable in vue stores, in order to avoid duplication
  • addresses webpack's devtool source mapping for a more coherent debug environment while preserving stacktraces for posthog

Related Issue(s)

part of #4673

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

…sionsMixin into a composable, fix webpack devtool source mapping

- the features mixin is cumbersome to use and bloats each component it's added to and cannot be used in vuex stores
- the persmissions mixin is not usable in vue stores, in order to avoid duplication
- addresses webpack's devtool source mapping for a more coherent debug environment while preserving stacktraces for posthog
@cstns cstns requested a review from joepavitt November 7, 2024 10:57
@cstns cstns self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (605166b) to head (1cd6d0f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4743   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14781    14781           
  Branches     3384     3384           
=======================================
  Hits        11646    11646           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns changed the title Sidebar Re-design prerequisites Sidebar Re-design: prerequisites Nov 7, 2024
@cstns cstns mentioned this pull request Nov 7, 2024
10 tasks
@joepavitt joepavitt self-requested a review November 11, 2024 13:54
@joepavitt joepavitt merged commit 7ec2ad6 into main Nov 11, 2024
13 checks passed
@joepavitt joepavitt deleted the sidebar-redesign_prerequisites branch November 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants