Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Re-design: Routing #4744

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Sidebar Re-design: Routing #4744

merged 1 commit into from
Nov 11, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Nov 7, 2024

Replace hardcoded router link paths with named routes, reorganize vue router and small styling adjustments

Description

  • replaced hardcoded router link paths with named routes
  • reorganized routes in order to correctly handle router-link active property and consistent behavior across page navigation and hierarchy

Related Issue(s)

part of #4673

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

… router and small styling adjustments

- replaced hardcoded router link paths with named routes
- reorganized routes in order to correctly handle router-link active property and consistent behavior across page navigation and hierarchy
@cstns cstns requested a review from joepavitt November 7, 2024 11:54
@cstns cstns self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (1cd6d0f) to head (eb09846).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4744   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14781    14781           
  Branches     3384     3384           
=======================================
  Hits        11646    11646           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns changed the title Sidebar Re-design Routing Sidebar Re-design: Routing Nov 7, 2024
@cstns
Copy link
Contributor Author

cstns commented Nov 7, 2024

Do not merge until #4743 passes review

@cstns cstns mentioned this pull request Nov 7, 2024
10 tasks
Base automatically changed from sidebar-redesign_prerequisites to main November 11, 2024 13:54
@joepavitt joepavitt merged commit 771a7ef into main Nov 11, 2024
13 checks passed
@joepavitt joepavitt deleted the sidebar-redesign_routing branch November 11, 2024 13:55
@cstns cstns mentioned this pull request Nov 13, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants