-
-
Notifications
You must be signed in to change notification settings - Fork 74
Update to efcore and .net 10 #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
niekschoemaker
wants to merge
12
commits into
FirebirdSQL:master
Choose a base branch
from
niekschoemaker:feature/efcore-10
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,679
−1,472
Open
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
025223e
EF Core 10 support.
niekschoemaker 54c42fa
Update Unit tests for EF Core 10
niekschoemaker 7c1d34c
Update build script to target .NET 10 for Firebird client libraries
niekschoemaker bea01d3
Merge branch 'master' into feature/efcore-10
niekschoemaker 44adff4
Merge branch 'master' into feature/efcore-10
cincuranet ba47967
Add version check for Firebird 5 in union tests
niekschoemaker b9f21ed
Fix name generation logic to prevent really long names with lots of d…
niekschoemaker 4bdd787
Replace explicit table name overrides with `SimpleTableNames` helper …
niekschoemaker 521ce97
Re-enable OUTER JOIN tests as this is supported since #1238
niekschoemaker e6cf6e0
Fix wrong indentation
niekschoemaker c65dde3
Re-enable wrongfully disabled tests for math translations
niekschoemaker 22e3edd
Fix wrapping
niekschoemaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,12 +16,13 @@ | |
| //$Authors = Jiri Cincura ([email protected]) | ||
|
|
||
| using FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.TestUtilities; | ||
| using Microsoft.EntityFrameworkCore; | ||
| using Microsoft.EntityFrameworkCore.Query; | ||
| using Microsoft.EntityFrameworkCore.TestUtilities; | ||
|
|
||
| namespace FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.Query; | ||
|
|
||
| public class AdHocAdvancedMappingsQueryFbTest : AdHocAdvancedMappingsQueryRelationalTestBase | ||
| public class AdHocAdvancedMappingsQueryFbTest(NonSharedFixture fixture) : AdHocAdvancedMappingsQueryRelationalTestBase(fixture) | ||
| { | ||
| protected override ITestStoreFactory TestStoreFactory => FbTestStoreFactory.Instance; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,13 +15,23 @@ | |
|
|
||
| //$Authors = Jiri Cincura ([email protected]) | ||
|
|
||
| using System.Threading.Tasks; | ||
| using FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.Helpers; | ||
| using FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.TestUtilities; | ||
| using Microsoft.EntityFrameworkCore; | ||
| using Microsoft.EntityFrameworkCore.Query; | ||
| using Microsoft.EntityFrameworkCore.TestUtilities; | ||
|
|
||
| namespace FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.Query; | ||
|
|
||
| public class AdHocComplexTypeQueryFbTest : AdHocComplexTypeQueryTestBase | ||
| public class AdHocComplexTypeQueryFbTest(NonSharedFixture fixture) : AdHocComplexTypeQueryTestBase(fixture) | ||
| { | ||
| protected override ITestStoreFactory TestStoreFactory => FbTestStoreFactory.Instance; | ||
|
|
||
| // Uses a custom type mapping DateTime to "datetime" which doesn't exist in Firebird. | ||
| [NotSupportedByProviderFact] | ||
| public override Task Complex_type_equality_with_non_default_type_mapping() | ||
| { | ||
| return base.Complex_type_equality_with_non_default_type_mapping(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,12 +16,13 @@ | |
| //$Authors = Jiri Cincura ([email protected]) | ||
|
|
||
| using FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.TestUtilities; | ||
| using Microsoft.EntityFrameworkCore; | ||
| using Microsoft.EntityFrameworkCore.Query; | ||
| using Microsoft.EntityFrameworkCore.TestUtilities; | ||
|
|
||
| namespace FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.Query; | ||
|
|
||
| public class AdHocManyToManyQueryFbTest : AdHocManyToManyQueryRelationalTestBase | ||
| public class AdHocManyToManyQueryFbTest(NonSharedFixture fixture) : AdHocManyToManyQueryRelationalTestBase(fixture) | ||
| { | ||
| protected override ITestStoreFactory TestStoreFactory => FbTestStoreFactory.Instance; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
...alTests/Query/Associations/ComplexTableSplitting/ComplexTableSplittingBulkUpdateFbTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * The contents of this file are subject to the Initial | ||
| * Developer's Public License Version 1.0 (the "License"); | ||
| * you may not use this file except in compliance with the | ||
| * License. You may obtain a copy of the License at | ||
| * https://github.com/FirebirdSQL/NETProvider/raw/master/license.txt. | ||
| * | ||
| * Software distributed under the License is distributed on | ||
| * an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND, either | ||
| * express or implied. See the License for the specific | ||
| * language governing rights and limitations under the License. | ||
| * | ||
| * All Rights Reserved. | ||
| */ | ||
|
|
||
| //$Authors = Niek Schoemaker (@niekschoemaker) | ||
|
|
||
| using System.Threading.Tasks; | ||
| using FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.Helpers; | ||
| using Microsoft.EntityFrameworkCore.Query.Associations.ComplexTableSplitting; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.Query.Associations.ComplexTableSplitting; | ||
|
|
||
| public class ComplexTableSplittingBulkUpdateFbTest( | ||
| ComplexTableSplittingFbFixture fixture, | ||
| ITestOutputHelper testOutputHelper) | ||
| : ComplexTableSplittingBulkUpdateRelationalTestBase<ComplexTableSplittingFbFixture>(fixture, testOutputHelper) | ||
niekschoemaker marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| { | ||
| [NotSupportedByProviderFact] | ||
| public override Task Update_inside_primitive_collection() | ||
| { | ||
| return base.Update_inside_primitive_collection(); | ||
| } | ||
| } | ||
28 changes: 28 additions & 0 deletions
28
...unctionalTests/Query/Associations/ComplexTableSplitting/ComplexTableSplittingFbFixture.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| * The contents of this file are subject to the Initial | ||
| * Developer's Public License Version 1.0 (the "License"); | ||
| * you may not use this file except in compliance with the | ||
| * License. You may obtain a copy of the License at | ||
| * https://github.com/FirebirdSQL/NETProvider/raw/master/license.txt. | ||
| * | ||
| * Software distributed under the License is distributed on | ||
| * an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND, either | ||
| * express or implied. See the License for the specific | ||
| * language governing rights and limitations under the License. | ||
| * | ||
| * All Rights Reserved. | ||
| */ | ||
|
|
||
| //$Authors = Niek Schoemaker (@niekschoemaker) | ||
|
|
||
| using FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.TestUtilities; | ||
| using Microsoft.EntityFrameworkCore.Query.Associations.ComplexTableSplitting; | ||
| using Microsoft.EntityFrameworkCore.TestUtilities; | ||
|
|
||
| namespace FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.Query.Associations.ComplexTableSplitting; | ||
|
|
||
| public class ComplexTableSplittingFbFixture : ComplexTableSplittingRelationalFixtureBase | ||
| { | ||
| protected override ITestStoreFactory TestStoreFactory | ||
| => FbTestStoreFactory.Instance; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.