Update to efcore and .net 10 #1245
Open
+2,679
−1,472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added translations tests for Temporal types - Applied refactorings done since EF Core 9
cincuranet
requested changes
Nov 28, 2025
src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/ComplianceFbTest.cs
Outdated
Show resolved
Hide resolved
...ore.Firebird.FunctionalTests/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.csproj
Show resolved
Hide resolved
...ionalTests/Query/Associations/ComplexTableSplitting/ComplexTableSplittingBulkUpdateFbTest.cs
Outdated
Show resolved
Hide resolved
...ql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Translations/MathTranslationsFbTest.cs
Outdated
Show resolved
Hide resolved
...FrameworkCore.Firebird.FunctionalTests/Query/Translations/MiscellaneousTranslationsFbTest.cs
Show resolved
Hide resolved
...d.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsSetOperationsFbTest.cs
Outdated
Show resolved
Hide resolved
...unctionalTests/Query/Associations/OwnedTableSplitting/OwnedTableSplittingProjectionFbTest.cs
Outdated
Show resolved
Hide resolved
...re.Firebird.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsFbFixture.cs
Outdated
Show resolved
Hide resolved
...ebird.FunctionalTests/Query/Associations/OwnedTableSplitting/OwnedTableSplittingFbFixture.cs
Show resolved
Hide resolved
...dSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/NorthwindSetOperationsQueryFbTest.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Alright, I fixed pretty much everything now, most things which are left open, so not fixed, are done for a reason as seen in the comments. Especially all the conversion tests as explained, the casts there are really odd and not supported by firebird (bool -> numbers, and vice versa) so I disabled those with that reason. Could also re-implement those tests with a custom implementation to test the behavior we do support, but not sure if that's preferred. And the updates are left open, as those are necessary to even compile, but could be split of into a seperate PR if necessary. |
niekschoemaker
force-pushed
the
feature/efcore-10
branch
from
5c34b0e to
22e3edd
Compare
Contributor
Author
|
Test for FB3.0 seems to hang, did pass on the fork, so retrigger should fix that but can't do that myself. |
cincuranet
approved these changes
Dec 6, 2025
Member
|
Great work! I restarted the leg and let's see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of JSON related and collections in columns tests have been disabled, as that is not supported.
Otherwise most tests are left enabled except for some specific ones, most of it due to outer joins and json related data.