refactor: use detected tool name everywhere (TOOL_NAME == detected name) - #16
Merged
Conversation
added 3 commits
March 6, 2026 12:40
Previously appliers used short internal names ('claude', 'gemini', 'copilot')
for TOOL_NAME, while detection returned full names ('claude-code', 'gemini-cli',
'github-copilot'). This required a get_applier() roundtrip in status.py just to
find the right manifest file.
Changes:
- ClaudeApplier.TOOL_NAME: 'claude' → 'claude-code'
- GeminiApplier.TOOL_NAME: 'gemini' → 'gemini-cli'
- CopilotApplier.TOOL_NAME: 'copilot' → 'github-copilot'
- Extractors: source_tool field updated to match (claude→claude-code, etc.)
- status.py: remove get_applier() indirection — ToolManifest(name) works directly
- status.py: bring in manifest-based consistency check (synced/out-of-sync)
- Tests updated throughout
- Remove _ALIASES from appliers/__init__.py and extractors/__init__.py
('claude', 'gemini', 'copilot' no longer accepted; use full names)
- get_applier() and get_extractor() now raise with a helpful message
listing valid tool names on invalid input
- README: update --tools examples to use full names (gemini-cli, not gemini)
- src/ui.py: update docstring example to 'claude-code'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Appliers used short internal names (
claude,gemini,copilot) forTOOL_NAMEwhile tool detection returned full names (claude-code,gemini-cli,github-copilot). This mismatch meantstatus.pyneeded aget_applier()roundtrip just to find the right manifest file — and made the naming confusing throughout.Changes
TOOL_NAME = "claude"TOOL_NAME = "claude-code"TOOL_NAME = "gemini"TOOL_NAME = "gemini-cli"TOOL_NAME = "copilot"TOOL_NAME = "github-copilot"source_toolfield updated to match (claude→claude-code, etc.)status.py: removedget_applier()indirection —ToolManifest(name)works directly; also brings in the manifest-basedsynced/out of syncconsistency checkResult
Detected name,
TOOL_NAME, manifest filename, andsource_toolin cache are all consistent — no more translation layer needed.207 tests passing.