fix: lazy applier paths, out-of-sync UI label, and status tests - #9
Merged
Conversation
added 2 commits
March 6, 2026 12:49
- status now distinguishes 'not synced' / 'synced' / 'out of sync' - 'out of sync' triggers when manifest-recorded files are missing on disk - uses applier TOOL_NAME for manifest lookup (e.g. 'claude' not 'claude-code') - adds test_manifest.py with 17 unit tests for ToolManifest + status logic - adds parametrized integration tests covering all 5 supported tools
- Lazify Path.home() usage in ClaudeApplier, GeminiApplier, WindsurfApplier, OpenClawApplier via helper functions (_claude_dir(), _claude_json(), etc.) - SKILL_DIR is now a @Property with getter/setter so test patches still work - Add missing 'override' param to OpenClawApplier.apply_mcp_servers() - Update test_appliers.py + test_e2e.py patches to target functions not constants - Parametrized TestStatus tests cover all 5 tools: cursor, claude-code, gemini-cli, windsurf, openclaw across not-synced / synced / out-of-sync states - Use isolated cache seeding (no blanket collect) to prevent real-home contamination
FZ2000
force-pushed
the
fix/3-status-synced-label-uses-manifest
branch
from
March 6, 2026 20:51
8c5e42a to
b5be4bd
Compare
FZ2000
changed the title
FZ2000
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The manifest-based
status.pyconsistency check (not synced / synced / out of sync) landed in main via PR #16. This PR contributes the remaining pieces that make it reliable and well-tested.Changes
Lazy
Path.home()in all appliersClaudeApplier,GeminiApplier,WindsurfApplier,OpenClawApplierpreviously evaluatedPath.home()at module import time (module-level constants). This caused silent test contamination and real-file writes whenHOMEwas monkeypatched in tests. All paths are now resolved lazily via helper functions called at use time.SKILL_DIRis a@propertywith getter/setter so existing test patches still work.ui.py—out of synclabel supportAdds the third status state so the table renders correctly when files go missing.
OpenClawApplier.apply_mcp_servers— missingoverrideparamCalling
syncon openclaw was silently failing (exception caught, manifest never saved) because the method signature didn't accept theoverridekwarg thatsync_helperspasses.Tests
test_manifest.py— 17 unit tests forToolManifest+ status logicTestStatuscovering all 5 tools (cursor,claude-code,gemini-cli,windsurf,openclaw) × 3 states (not synced/synced/out of sync)collectcalls to prevent real-home contamination across test runsTest results
226 passing (full suite) · 106 passing (Docker-equivalent clean-HOME run)