-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding riscv cycle counter #348
base: master
Are you sure you want to change the base?
Conversation
The inclusion of the cycle counter (including support for rv32 in addition to rv64) is already part of the various RISC-V "V" efforts. |
understood. this is a small fix and allows fftw3 to work on riscv processors that currently do not have vector hardware support. as of right now, the different riscv vector software support implementations are a block for using fftw3 on riscv. |
@@ -1,6 +1,7 @@ | |||
/* | |||
* Copyright (c) 2003, 2007-14 Matteo Frigo | |||
* Copyright (c) 2003, 2007-14 Massachusetts Institute of Technology | |||
* Copyright (c) 2024 Christopher Taylor, Tactical Computing Labs, LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MIT will require a copyright assignment to merge PRs like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a problem, can you send or post information on how that process works?
I understand the urgency; but I don't think this implementation is satisfactory for upstreaming: If there's some urgency, I would suggest merging separately the RISC-V version from here. Edit: alternative proposed in #361 |
adds riscv cycle counter support to fftw3