Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding riscv cycle counter #348

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adding riscv cycle counter #348

wants to merge 2 commits into from

Conversation

ct-clmsn
Copy link

@ct-clmsn ct-clmsn commented Mar 5, 2024

adds riscv cycle counter support to fftw3

@rdolbeau
Copy link
Contributor

rdolbeau commented Jul 14, 2024

The inclusion of the cycle counter (including support for rv32 in addition to rv64) is already part of the various RISC-V "V" efforts.

@ct-clmsn
Copy link
Author

understood. this is a small fix and allows fftw3 to work on riscv processors that currently do not have vector hardware support. as of right now, the different riscv vector software support implementations are a block for using fftw3 on riscv.

@@ -1,6 +1,7 @@
/*
* Copyright (c) 2003, 2007-14 Matteo Frigo
* Copyright (c) 2003, 2007-14 Massachusetts Institute of Technology
* Copyright (c) 2024 Christopher Taylor, Tactical Computing Labs, LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIT will require a copyright assignment to merge PRs like this.

Copy link
Author

@ct-clmsn ct-clmsn Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a problem, can you send or post information on how that process works?

@rdolbeau
Copy link
Contributor

rdolbeau commented Jul 19, 2024

I understand the urgency; but I don't think this implementation is satisfactory for upstreaming:
(a) no support for RV32
(b) hard-to-understand csrr when there is dedicated aliases like rdcycle and rdtime
(c) if this is using rdcycle, then user-land access was deprecated (security...) and will no longer be working Real Soon Now. Recent kernels on recent hardware have already dropped support (e.g. the manufacturer's kernel on the SpacemiT K1 SoC at least).

If there's some urgency, I would suggest merging separately the RISC-V version from here.

Edit: alternative proposed in #361

@rdolbeau rdolbeau mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants