-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Package move com.eppo.sdk
-> cloud.eppo
#83
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,25 @@ | ||
package com.eppo.sdk.helpers; | ||
package cloud.eppo; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. on a conceptual level, is the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. both are separate, completely individual libraries. they can share the same package names though, AFAIK there are no constraints preventing that |
||
|
||
import java.io.IOException; | ||
import java.io.InputStream; | ||
import java.util.Properties; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
public class AppDetails { | ||
class AppDetails { | ||
private static final Logger log = LoggerFactory.getLogger(AppDetails.class); | ||
static AppDetails instance; | ||
private final String version; | ||
private final String name; | ||
|
||
public static AppDetails getInstance() { | ||
static AppDetails getInstance() { | ||
if (instance == null) { | ||
instance = new AppDetails(); | ||
} | ||
return instance; | ||
} | ||
|
||
public AppDetails() { | ||
AppDetails() { | ||
Properties prop = new Properties(); | ||
try { | ||
prop = readPropertiesFile("app.properties"); | ||
|
@@ -30,15 +30,15 @@ public AppDetails() { | |
this.name = prop.getProperty("app.name", "java-server-sdk"); | ||
} | ||
|
||
public String getVersion() { | ||
String getVersion() { | ||
return this.version; | ||
} | ||
|
||
public String getName() { | ||
String getName() { | ||
return this.name; | ||
} | ||
|
||
public static Properties readPropertiesFile(String fileName) throws IOException { | ||
static Properties readPropertiesFile(String fileName) throws IOException { | ||
ClassLoader loader = Thread.currentThread().getContextClassLoader(); | ||
Properties props = new Properties(); | ||
InputStream resourceStream = loader.getResourceAsStream(fileName); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,18 @@ | ||
package com.eppo.sdk.helpers; | ||
package cloud.eppo; | ||
|
||
import java.util.Timer; | ||
import java.util.TimerTask; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
public class FetchConfigurationsTask extends TimerTask { | ||
class FetchConfigurationsTask extends TimerTask { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
private static final Logger log = LoggerFactory.getLogger(FetchConfigurationsTask.class); | ||
private final Runnable runnable; | ||
private final Timer timer; | ||
private final long intervalInMillis; | ||
private final long jitterInMillis; | ||
|
||
public FetchConfigurationsTask( | ||
FetchConfigurationsTask( | ||
Runnable runnable, Timer timer, long intervalInMillis, long jitterInMillis) { | ||
this.runnable = runnable; | ||
this.timer = timer; | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumped major version since it's a breaking change