-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Package move com.eppo.sdk
-> cloud.eppo
#83
Conversation
@@ -11,7 +11,7 @@ java { | |||
} | |||
|
|||
group = 'cloud.eppo' | |||
version = '3.1.1-SNAPSHOT' | |||
version = '4.0.0-SNAPSHOT' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumped major version since it's a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with just a thought about the package naming for you to consider (could be an overthought; I trust your judgement).
|
||
import java.util.Timer; | ||
import java.util.TimerTask; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
public class FetchConfigurationsTask extends TimerTask { | ||
class FetchConfigurationsTask extends TimerTask { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -1,25 +1,25 @@ | |||
package com.eppo.sdk.helpers; | |||
package cloud.eppo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a conceptual level, is the android
SDK a sub-implementation of the java SDK or are the android
and java-server
SDKs both parallel flavours of a jvm
SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both are separate, completely individual libraries. they can share the same package names though, AFAIK there are no constraints preventing that
So this is consistent with Android