Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Package move com.eppo.sdk -> cloud.eppo #83

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

felipecsl
Copy link
Contributor

@felipecsl felipecsl commented Oct 28, 2024

So this is consistent with Android

@felipecsl felipecsl requested review from aarsilv and typotter October 28, 2024 19:17
@@ -11,7 +11,7 @@ java {
}

group = 'cloud.eppo'
version = '3.1.1-SNAPSHOT'
version = '4.0.0-SNAPSHOT'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumped major version since it's a breaking change

Copy link
Collaborator

@typotter typotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with just a thought about the package naming for you to consider (could be an overthought; I trust your judgement).


import java.util.Timer;
import java.util.TimerTask;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class FetchConfigurationsTask extends TimerTask {
class FetchConfigurationsTask extends TimerTask {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,25 +1,25 @@
package com.eppo.sdk.helpers;
package cloud.eppo;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a conceptual level, is the android SDK a sub-implementation of the java SDK or are the android and java-server SDKs both parallel flavours of a jvm SDK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both are separate, completely individual libraries. they can share the same package names though, AFAIK there are no constraints preventing that

@felipecsl felipecsl merged commit 62a92ee into main Oct 29, 2024
4 checks passed
@felipecsl felipecsl deleted the felipecsl--cloud-eppo branch October 29, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants