chore: Package move com.eppo.sdk -> cloud.eppo
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
commented
Oct 28, 2024
| @@ -11,7 +11,7 @@ java { | |||
| } | |||
|
|
|||
| group = 'cloud.eppo' | |||
| version = '3.1.1-SNAPSHOT' | |||
| version = '4.0.0-SNAPSHOT' | |||
There was a problem hiding this comment.
bumped major version since it's a breaking change
typotter
approved these changes
Oct 28, 2024
|
|
||
| import java.util.Timer; | ||
| import java.util.TimerTask; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class FetchConfigurationsTask extends TimerTask { | ||
| class FetchConfigurationsTask extends TimerTask { |
| @@ -1,25 +1,25 @@ | |||
| package com.eppo.sdk.helpers; | |||
| package cloud.eppo; | |||
There was a problem hiding this comment.
on a conceptual level, is the android SDK a sub-implementation of the java SDK or are the android and java-server SDKs both parallel flavours of a jvm SDK?
There was a problem hiding this comment.
both are separate, completely individual libraries. they can share the same package names though, AFAIK there are no constraints preventing that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is consistent with Android