Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content about the benefits/value of joining FEGA #59

Merged
merged 7 commits into from
May 16, 2023

Conversation

BioDataAdmin
Copy link
Contributor

Description

Add chapter about the benefits/value of joining FEGA

Motivation and Context

(#25)

What should reviewers focus on?

Review text

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING.md guide.
  • My changes follow the code style of this project.
  • I have updated supporting documentation, if required.
  • I have added my details to the CONTRIBUTORS.yaml file.

Drafted "What are the benefits of joining Federated EGA?"
added another line before the title
reenforced discoverability advantages, added network expert, fixed typos.
added a break between the table and the new section
minor typos fixed
@M-casado M-casado self-requested a review May 16, 2023 11:11
@M-casado M-casado added documentation Improvements or additions to documentation FEGA-thon A label assigned to PRs and Issues related to 2023 FEGA-thon labels May 16, 2023
@M-casado M-casado self-assigned this May 16, 2023
Copy link
Collaborator

@M-casado M-casado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URLs are in markdown format, but @BioDataAdmin, could you format them using the existing HTML format?

I would change them if I could, and add a few other bullet points, but I think the PR is blocked for edits from maintainers. So as soon as the hyperlinks are fixed I'll modify them in my fork :)

changed markdown links to html
@BioDataAdmin
Copy link
Contributor Author

I have fixed the hyperlinks!

@M-casado M-casado merged commit 5d67ce8 into EGA-archive:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation FEGA-thon A label assigned to PRs and Issues related to 2023 FEGA-thon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants