-
Notifications
You must be signed in to change notification settings - Fork 64
{2023.06}[2023b] RAxML 8.2.13 #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PetrKralCZ
wants to merge
2
commits into
EESSI:main
Choose a base branch
from
PetrKralCZ:2023.06-2023b-RAxML
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not going to work on systems that don't have AVX2, you need to create a variant of https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/r/RAxML/RAxML-8.2.13-gompi-2023a-standard.eb with a newer toolchain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is a case where I think we should diverge from the "same modules everywhere" goal.
The AVX2 variant of RAxML is definitely worth installing for
x86_64
CPUs, but clearly doesn't make any sense foraarch64
.So we should install "fake" modules for the latter, and get them to produce a meaningful error to explain why that installation is not available on
aarch64
targets?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to make this exception, we need a better easyconfig. For example, https://github.com/stamatak/standard-RAxML/blob/master/Makefile.HYBRID.gcc has the mechanism to support both x86 and Arm, we should really be using that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR for this particular case in easybuilders/easybuild-easyconfigs#23975
RAxML does seem to have some intrinsics available, but the specific code targeted Haswell and hasn't been touched in 10 years, I think a native CPU compilation is a reasonable option