Skip to content

Fix permission issue for newly created dirs/files in install_scripts.sh #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Jul 15, 2025

This issue surfaced when building the init dir for the new 2025.06 version, and only on Deucalion: the permissions on the init/bash and modules/EESSI/2025.lua files were wrong, and didn't have read permissions for others. I suspect it's related to the default umask on Deucalion (?).

I noticed that install_scripts.sh already used a special procedure in sed_update_if_changed (see https://github.com/EESSI/software-layer-scripts/blob/main/install_scripts.sh#L58), which explicitly sets the umask and uses cat for copying the files (apparently to retain the permissions?). This PR uses the same approach for copying missing/modified files (instead of using cp). #37 (comment) shows that this solves the issue on Deucalion.

@gpu-bot-ugent
Copy link

gpu-bot-ugent bot commented Jul 15, 2025

Instance eessi-bot-vsc-ugent is configured to build for:

  • architectures: x86_64/amd/zen3
  • repositories: eessi.io-2023.06-compat, eessi.io-2023.06-software, eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@casparvl casparvl merged commit 9411674 into EESSI:main Jul 15, 2025
51 checks passed
@gpu-bot-ugent
Copy link

gpu-bot-ugent bot commented Jul 15, 2025

PR merged! Moved [] to /scratch/gent/vo/002/gvo00211/SHARED/trash_bin/EESSI/software-layer-scripts/2025.07.15

@bedroge bedroge deleted the fix_umask_issue_new_dirs branch July 15, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants