External gravity wave#325
Merged
Merged
Conversation
|
Nice @jeremy-lilly |
jeremy-lilly
commented
May 27, 2025
jeremy-lilly
commented
May 27, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
reviewed
May 29, 2025
cbegeman
requested changes
May 29, 2025
Co-authored-by: Carolyn Begeman <cbegeman@lanl.gov>
Co-authored-by: Carolyn Begeman <cbegeman@lanl.gov>
cbegeman
approved these changes
Jun 3, 2025
Collaborator
cbegeman
left a comment
cbegeman
left a comment
There was a problem hiding this comment.
@jeremy-lilly Thanks for addressing all of my comments and suggestions! Great work here. This time integrator convergence test will be useful as we test Omega as well.
Collaborator
|
@jeremy-lilly I see that some items in the checklist are not marked as completed. Can you look those over and let me know if this is ready to merge? |
Contributor
Author
TestingAll tasks have been tested using MPAS-O on Perlmutter. |
Contributor
Author
Should be good to go! |
Collaborator
|
Great! Thanks for all your hard work on this @jeremy-lilly! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements the test case from #187 on top of modern Polaris.
We create a new ocean task for testing the temporal convergence rate of time-stepping schemes. The case is that of a simple external gravity wave on an aquaplant. The normal velocity is initialized to zero and the layer thickness is initialized as a Gaussian bump. The PR also implements a version of the task for local time-stepping schemes. Convergence plots produced by this task for
FB_LTSare given below.Note that the external gravity wave case was chosen so as to have as few terms in the tendencies as possible -- because of this, both the LTS and FB-LTS schemes show their "true" order of convergence, rather than the first order convergence caused by the operator splitting that both the
LTSandFB_LTScodes implement.Big thanks to @gcapodag who wrote a lot of the original test case.
Checklist
Testingcomment in the PR documents testing used to verify the changes