Skip to content

Fix incorrect import in external gravity wave#336

Merged
xylar merged 1 commit into
E3SM-Project:mainfrom
xylar:fix-external-gravity
Jun 6, 2025
Merged

Fix incorrect import in external gravity wave#336
xylar merged 1 commit into
E3SM-Project:mainfrom
xylar:fix-external-gravity

Conversation

@xylar
Copy link
Copy Markdown
Collaborator

@xylar xylar commented Jun 6, 2025

This path presumably changed between the beginning of development and merging.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

This path presumably changed between the beginning of development
and merging.
@xylar xylar self-assigned this Jun 6, 2025
@xylar xylar added bug Something isn't working ocean Related to the ocean component labels Jun 6, 2025
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jun 6, 2025

This got missed in #325.

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jun 6, 2025

@jeremy-lilly, can you run a test to see if this works for you? I want to make sure this import is the only conflict that needs to be resolved here.

@jeremy-lilly
Copy link
Copy Markdown
Contributor

@jeremy-lilly, can you run a test to see if this works for you? I want to make sure this import is the only conflict that needs to be resolved here.

Testing

I just ran all four variations of the task from this branch on perlmutter -- all run as expected.

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jun 6, 2025

Thanks @jeremy-lilly ! I'm on vacation and not in a great position to test so I really appreciate it.

@xylar xylar merged commit 224a3c6 into E3SM-Project:main Jun 6, 2025
5 checks passed
@xylar xylar deleted the fix-external-gravity branch June 6, 2025 17:12
@jeremy-lilly
Copy link
Copy Markdown
Contributor

Thanks @jeremy-lilly ! I'm on vacation and not in a great position to test so I really appreciate it.

No problem at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ocean Related to the ocean component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants