Skip to content

fix: add SAML response XML digital signature verification to prevent critical auth bypass #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DivyashreeR008 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add SAML response XML digital signature verification to prevent critical auth bypass #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions services/auth-service/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,6 +1396,35 @@ app.post('/saml/acs', createUserRateLimiter('saml_acs', 20), async (req, res) =>
if (!signatureVerified) {
return res.status(401).json({ message: 'SAML signature verification failed' });
}

const conditions = doc.getElementsByTagNameNS
? doc.getElementsByTagNameNS('urn:oasis:names:tc:SAML:2.0:assertion', 'Conditions')
: doc.getElementsByTagName('Conditions');

if (conditions.length > 0) {
const condition = conditions[0];
const notBefore = condition.getAttribute('NotBefore');
const notOnOrAfter = condition.getAttribute('NotOnOrAfter');
const now = new Date();

if (notBefore && now < new Date(notBefore)) {
return res.status(401).json({ message: 'SAML assertion is not yet valid (NotBefore)' });
}

if (notOnOrAfter && now >= new Date(notOnOrAfter)) {
return res.status(401).json({ message: 'SAML assertion has expired (NotOnOrAfter)' });
}

const audienceNodes = doc.getElementsByTagNameNS
? doc.getElementsByTagNameNS('urn:oasis:names:tc:SAML:2.0:assertion', 'Audience')
: doc.getElementsByTagName('Audience');

for (let i = 0; i < audienceNodes.length; i++) {
if (audienceNodes[i].textContent === SAML_IDP_ENTITY_ID) {
break;
}
}
}
}

const nameIdMatch = decodedXml.match(/<saml2:NameID[^>]*>([^<]+)<\/saml2:NameID>/);
Expand Down