fix: add SAML response XML digital signature verification to prevent critical auth bypass - #1
Open
DivyashreeR008 wants to merge 1 commit into
Open
fix: add SAML response XML digital signature verification to prevent critical auth bypass#1DivyashreeR008 wants to merge 1 commit into
DivyashreeR008 wants to merge 1 commit into
Conversation
DivyashreeR008
force-pushed
the
fix/saml-acs-signature-verification
branch
from
June 16, 2026 11:47
cbdf6fb to
255c955
Compare
DivyashreeR008
pushed a commit
that referenced
this pull request
Jun 17, 2026
…pdate feat: update header section UI with sticky scroll shadow, user dropdo…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical SAML auth bypass vulnerability (CVSS 9.8+). The
/saml/acsendpoint was accepting SAMLResponses without verifying the XML digital signature, allowing anyone with a crafted SAMLResponse to impersonate any user.Root Cause
The SAML ACS handler decoded the base64
SAMLResponseand extracted user attributes via regex directly from the XML string ??? but never validated the<ds:Signature>element.Fix
xml-crypto+@xmldom/xmldomfor XML signature verificationSAML_IDP_CERT??? the IdP's X.509 public certificate (PEM format)<Signature>elements in thexmldsignamespaceSAML_IDP_CERTis unset in production, a warning is loggedFiles Changed
services/auth-service/index.jsservices/auth-service/package.json@xmldom/xmldomandxml-cryptodepsservices/auth-service/.env.exampleSAML_IDP_CERTconfig entry