Grab keyboard when the game is not launched with -nomousegrab#665
Merged
Grab keyboard when the game is not launched with -nomousegrab#665
Conversation
Avoid system shortcuts getting in the way of the game
pzychotic
approved these changes
Feb 23, 2025
Member
pzychotic
left a comment
There was a problem hiding this comment.
This also works on Windows to prevent tabbing out of the game when accidentally hitting the windows key.
I'm just reluctant to merge since the referenced issue to be closed derailed into another topic.
Member
Author
|
I edited the description so it will not close the issue automatically. In the meantime, I think we can merge this. I wanted to add the release of the mouse grab when the game is paused in this PR, but unfortunately we'll need to fix the mouse input code first ( see #634) |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Avoid system shortcuts getting in the way of the game by grabbing the keyboard. Per the doc, only alt+tab is allowed when the game is in full-screen (https://wiki.libsdl.org/SDL3/SDL_SetWindowKeyboardGrab)
Related Issues
#664
Will change signature when ported to SDL3 (cf #663 )