Revert "Grab keyboard when the game is not launched with -nomousegrab"

[jengelh]

This reverts commit 1707ee1.

Under X11, grabbing the keyboard has negative side effect of rendering Alt-Tab useless in windowed mode. Multimedia volume keys are rendered useless in windowed or fullscreen mode. When execution of descent3 is suspended (e.g. when running under a debugger), it would be impossible to get out of it even in fullscreen mode, since the SDL handler does not run.

Looking at other games, I find that many other engines (chocolate-doom, gzdoom, yquake2, sauerbraten, but also gl-117) do not exercise keyboard grabbing either and only use relative mouse mode (mouse grab).

Pull Request Type

• Runtime changes
  • Input changes

Related Issues

#665

Checklist

• I have tested my changes locally and verified that they work as intended.
• I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

[Lgt2x]

I usually run debug builds with -nomousegrab, which also disables keyboard grab, so this has not been much an issue for me, but I agree that grabbing keyboard is not a great solution. That's the only way I found to solve #664 , because otherwise the OS has precedence over the game (which we want... most of the time?). I'm fine to assume that #664 should be solved with proper Desktop environment configuration and not by the game.