Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apollo] Tighten namespace around metrics #2539

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Draft

[Apollo] Tighten namespace around metrics #2539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .in-toto/tag.c0daa59b.link
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apollo/manifest.json
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@
"creates_events": false
},
"metrics": {
"prefix": "apollo.",
"prefix": "apollo.operations.",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if the manifest supports having an array here? It would seem safer conceptually to me — to preserve behavior of our legacy apollo.engine. namespace — to have this be ["apollo.operations.", "apollo.engine."]and _not_ addapollo.router.` to that list (which is the primary set we're trying to unblock tag-editing access for).

"check": [
"apollo.operations.count",
"apollo.engine.operations.count"

Unchanged files with check annotations Beta

View file
apollo/metadata.csv
metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric
apollo.operations.count,gauge,,operation,,"Number of GraphQL operations (queries and mutations) processed.",0,apollo_engine,operation count,
apollo.operations.latency.avg,gauge,,millisecond,,"Total request duration for a GraphQL operation, average.",-1,apollo_engine,average latency,