[Apollo] Tighten namespace around metrics #2539
Draft
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This aims to tighten the namespace which are part of our DataDog Marketplace integration to just the set of metrics which are emitted (from the SaaS side of our Apollo product) which pertain to the Marketplace integration rather than those that are emitted by our (different) on-prem product, Apollo Router which emits its metrics into an
apollo.router.
-prefixed namespace. Thisapollo.router.
namespace should not prevent users from losing control over the management of tags in their UI.What this PR does not do is remove
apollo.engine.
from the list ofchecks
, though it is tempting to do that at the same time. What is not clear is what the implications of that are as this is a deprecated namespace.Relates to #2529
Motivation
We're opening this only because we're finding customers who are using our on-prem metrics are being forbidden by the DataDog UI to adjust those metrics in the way they would manage tags on other metrics.
Review checklist
no-changelog
label attachedAdditional Notes
Happy to help satisfy the Review checklist, but primarily looking for feedback if this will accomplish what we want, or if there is another way this should be done.