Skip to content

test: fix e2e failures on CI runners #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanteCpp merged 1 commit into from
Jul 9, 2026
Merged

test: fix e2e failures on CI runners #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/layer-dialog.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ LI 45 35 60 15 0

async function openLayerDialog(page: import('@playwright/test').Page) {
await page.locator('button', { hasText: 'View' }).hover();
await page.getByText('Layer options...', { exact: true }).click();
await page.getByText('Layer options', { exact: true }).click();
await expect(page.locator('[data-testid="layer-dialog"]')).toBeVisible();
}

Expand Down
22 changes: 13 additions & 9 deletions test/e2e/text-selection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,26 @@ import {
} from './utils';

test('text selection follows glyph ink instead of the whole string box', async ({ page }) => {
// Large text (six=40 → 69px font) so inter-glyph ink gaps dwarf the
// hit-test padding (capped at 0.75 logical units) even when the CI
// platform substitutes Courier New with another monospace font whose
// ink bounds differ by a few pixels.
await gotoApp(page);
await loadCircuit(page, '[FIDOCAD]\nTY 50 50 14 10 0 0 0 Courier++New String\n');
await loadCircuit(page, '[FIDOCAD]\nTY 50 50 56 40 0 0 0 Courier++New String\n');
await pressKey(page, 'a');

const hitPoints = await page.evaluate(() => {
const canvas = document.createElement('canvas');
canvas.width = 100;
canvas.height = 100;
canvas.width = 400;
canvas.height = 400;
const ctx = canvas.getContext('2d')!;
ctx.font = '17px "Courier New", monospace';
ctx.font = '69px "Courier New", monospace';

const inkBounds = (character: string) => {
const originX = 30;
const baseline = 60;
const originX = 100;
const baseline = 250;
ctx.clearRect(0, 0, canvas.width, canvas.height);
ctx.font = '17px "Courier New", monospace';
ctx.font = '69px "Courier New", monospace';
ctx.textBaseline = 'alphabetic';
ctx.fillStyle = '#000';
ctx.fillText(character, originX, baseline);
Expand All @@ -51,15 +55,15 @@ test('text selection follows glyph ink instead of the whole string box', async (
};
};

const fontAscent = ctx.measureText('M').actualBoundingBoxAscent || 17 * 0.8;
const fontAscent = ctx.measureText('M').actualBoundingBoxAscent || 69 * 0.8;
const s = inkBounds('S');
const t = inkBounds('t');
const g = inkBounds('g');
const tOrigin = ctx.measureText('St').width - t.width;
const gOrigin = ctx.measureText('String').width - g.width;
const gapStart = s.right;
const gapEnd = tOrigin - t.left;
const verticalScale = (14 * 22) / (40 * 10);
const verticalScale = (56 * 22) / (40 * 40);

return {
gap: {
Expand Down
Loading