test: fix e2e failures on CI runners#34
Merged
Merged
Conversation
- layer-dialog: menu labels no longer render a trailing ellipsis (stripped by menuLabel() in MenuBar), so match "Layer options" - text-selection: use 4x larger text (six=40, 69px font) so glyph ink gaps dwarf the 0.75-unit hit padding even when the platform substitutes Courier New with another monospace font, as the Linux CI runners do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 3 e2e failures introduced by b9bcd91:
menuLabel()inMenuBar.tswhich strips trailing ellipses from menu labels, but the test still located the item by'Layer options...'. Updated to'Layer options'.Sandtin 17px Courier New. The Linux CI runners substitute Courier New with a different monospace font whose glyph ink differs by a few pixels, collapsing the ~2.5px gap into the hit-test padding (0.75 logical units per side). Scaled the text 4× (six=40 → 69px font, same aspect ratio): ink gaps grow 4× while the padding stays capped at 0.75, leaving a comfortable margin under any monospace substitution.Testing