Repository navigation
docs: fix the reference links in SPF_BUILDER - #4914
Merged
TomOnTime merged 1 commit intoSep 19, 2026
Merged
Conversation
- Put the `[multi-string]` and `[record-size]` definitions on separate lines, so both links render instead of showing as plain text. Refs DNSControl#4634
Member
Author
|
Here is the GitBook preview URL with the working "multiple strings" and "not go higher than 450" links: |
This was referenced Sep 19, 2026
TomOnTime
pushed a commit
that referenced
this pull request
Sep 19, 2026
This GitHub pull request regenerates `commands/types/dnscontrol.d.ts` with `go generate ./...`. #4914 put the two reference link definitions in `documentation/language-reference/domain-modifiers/SPF_BUILDER.md` on separate lines, but I didn't regenerate the TypeScript definitions that are built from that page. Since then the "Check: go (build/fmtjson/mod-tidy/generate/fmt/fix)" check fails on every pull request based on `main`, for example #4917, because `go generate` leaves `dnscontrol.d.ts` modified. The diff is only the generated file: the `[multi-string]` and `[record-size]` definitions move to their own line, as in the documentation. I ran `go generate ./...` on the current `main` and it changes no other files. Refs #4914 ## AI-attributie Assisted-by: Claude Code:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4634. While going through the recently merged pull requests, I noticed that two links on https://docs.dnscontrol.org/language-reference/domain-modifiers/spf_builder don't work. The
txtMaxSizedescription shows "[multiple strings][multi-string]" and "[not go higher than 450][record-size]" as plain text, because both reference definitions are on the same line inSPF_BUILDER.md, so neither is recognized as a definition. That line dates back to #1809.This GitHub pull request puts each definition on its own line. Reference links with one definition per line render fine on GitBook, as on the "Writing new DNS providers" page.
AI-attributie
Assisted-by: Claude Code:claude-opus-5