Repository navigation
ci: set a Conventional Commits prefix for Dependabot - #4917
Merged
TomOnTime merged 2 commits intoSep 19, 2026
Merged
Conversation
- Add `commit-message.prefix: "build"` with `include: "scope"` to every ecosystem in `.github/dependabot.yml`, so Dependabot titles pull requests `build(deps): ...` and `build(deps-dev): ...` and they pass the `PR: Commitlint` check (DNSControl#4916 failed on `Build(deps-dev): Bump ...`).
Member
Author
TomOnTime
pushed a commit
that referenced
this pull request
Sep 19, 2026
This GitHub pull request regenerates `commands/types/dnscontrol.d.ts` with `go generate ./...`. #4914 put the two reference link definitions in `documentation/language-reference/domain-modifiers/SPF_BUILDER.md` on separate lines, but I didn't regenerate the TypeScript definitions that are built from that page. Since then the "Check: go (build/fmtjson/mod-tidy/generate/fmt/fix)" check fails on every pull request based on `main`, for example #4917, because `go generate` leaves `dnscontrol.d.ts` modified. The diff is only the generated file: the `[multi-string]` and `[record-size]` definitions move to their own line, as in the documentation. I ran `go generate ./...` on the current `main` and it changes no other files. Refs #4914 ## AI-attributie Assisted-by: Claude Code:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This GitHub pull request sets
commit-message.prefix: "build"withinclude: "scope"for every ecosystem in.github/dependabot.yml, so Dependabot titles its pull requestsbuild(deps): …andbuild(deps-dev): …instead ofBuild(deps): …. Since #4873 thePR: Commitlintcheck lints the pull request title, and #4916 (Build(deps-dev): Bump prettier from 3.9.5 to 3.9.6) is the first Dependabot pull request to fail it, on bothtype-enumandsubject-case. Thebuildtype keeps these pull requests in the same "CI/CD:" changelog group as the currentBuild(deps)titles.The prefix fixes the type, but not the capital in "Bump". Dependabot copies the capitalisation from its last commit on
main(seecapitalise_first_word_from_last_dependabot_commit_stylein https://github.com/dependabot/dependabot-core/blob/main/common/lib/dependabot/pull_request_creator/pr_name_prefixer.rb), which is stillBuild(deps): Bump joi from 18.2.3 to 18.2.9 (#4872). Squash-merging #4916 asbuild(deps-dev): bump prettier from 3.9.5 to 3.9.6makes that the last Dependabot commit, and from then on Dependabot writes "bump" in lowercase. I checked both titles locally withnpx commitlint: they pass, while the current title of #4916 fails.Refs #4916
AI-attributie
Assisted-by: Claude Code:claude-opus-5