-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 2.1.2 and 2.1.3 release changes #2204
Merged
+162
−128
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c1313af
Change gas
chipshort a4f318f
Add changelog entry
chipshort 101ca1f
chore: Release
chipshort e03585e
Bump module serialization version
chipshort 1a369f8
Fix module version in tests
chipshort b3e61d4
Add changelog entry
chipshort 6f61673
chore: Release
chipshort df673aa
Add note about module serialization version to cost function
chipshort 011eddd
Merge branch 'main' into co/add-note-to-cost-fn
chipshort ac0579f
Merge branch 'main' into co/add-note-to-cost-fn
chipshort File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Add note about module serialization version to cost function
commit df673aa72e1eea9b3dfe1996bc0f78083d6db697
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Now I was wondering if/how we can turn this function into something we can hash and add to the caching path. Either by serializing the function (some scripting language) or serialize the op -> cost as a table/map. Could you create a ticket for that as mid or long-term improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also wondering if we can test the cache compatibility by having a test with a cache folder with one wasm + module file inside and testing that it can be executed and works as expected (same gas, etc.).
That would probably catch some panics on the wasmer side and if we assert gas, also gas cost changes.