Merge 2.1.2 and 2.1.3 release changes #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // | ||
| // Please note that any changes to this function need to be accompanied by a bump of | ||
| // `MODULE_SERIALIZATION_VERSION` to avoid cached modules from using different amounts of gas | ||
| // compared to newly compiled ones. |
There was a problem hiding this comment.
Nice!
Now I was wondering if/how we can turn this function into something we can hash and add to the caching path. Either by serializing the function (some scripting language) or serialize the op -> cost as a table/map. Could you create a ticket for that as mid or long-term improvement?
There was a problem hiding this comment.
I was also wondering if we can test the cache compatibility by having a test with a cache folder with one wasm + module file inside and testing that it can be executed and works as expected (same gas, etc.).
That would probably catch some panics on the wasmer side and if we assert gas, also gas cost changes.
webmaster128
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a note to the cost function